Summary:
[copy-pasted from T10500:]
Problems with the current term:
- It's a somewhat severe-sounding technical term that doesn't intrinsically mean much to the average person. To the extent that it does, the connotations may be negative (e.g. when a misbehaving kid is being kept out of school)
- Our two major closed-source desktop competitors (macOS and Windows) both use the term "Sleep", so user familiarity with "Suspend" is low and falling all the time
I'd like to propose that we use "Sleep" instead, to address the above issues. It's a nicer
word in general, and since it's what our competitors use, we benefit from user familiarity.
We also recently adopted a moon icon with Zs for this, which visually connotes sleep. So it
would make sense to update the string too, because then the string and the icon will both
match.
Test Plan:
KRunner, searched for "Sleep": {F6640273}
KRunner, searched for "Suspend": {F6640284}
Kickoff, searched for "Sleep": {F6640309}
Kickoff, searched for "Suspend": {F6640315}
SDDM theme: {F6626026}
Logout screen: {F6626010}
Logout widget, UI: {F6626034}
Logout widget, config: {F6626035}
Reviewers: #vdg, #plasma, davidedmundson, filipf, mart
Reviewed By: #vdg, #plasma, filipf, mart
Subscribers: abetts, filipf, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10500
Differential Revision: https://phabricator.kde.org/D19185
Summary:
The WaylandPrivate::virtualDesktopManagement object is loaded
asyncronously.
It's null until we finish fetching the registry.
A code path could call the desktopNames in that time.
Test Plan:
Had a crash
Couldn't reproduce reliably
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19029
Summary:
load() is called a few times and different states. After the change I
also get the warning on a regular load.
This patch returns early whilst we're in the loading state, but still
prints the warning should kactivitymanagerd fail.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18922
Summary: Settings are ported to QtQuickControls 2 and now use a Kirigami Form Layout.
Test Plan:
Before:
{F6633459}
After:
{F6633461}
Reviewers: #vdg, #plasma, ngraham, davidedmundson
Reviewed By: #vdg, #plasma, ngraham, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19289
Summary: Currently NoDisplay services are shown, which doesn't make much sense.
Test Plan: Installed and looked through the menu, no excessive or duplicate items anymore.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19157
Summary: Currently NoDisplay services are shown, which doesn't make much sense.
Test Plan: Installed and looked through the menu, no excessive or duplicate items anymore.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19157
Summary:
--when the user has enabled PLASMA_USE_QT_SCALING
under X11 environment the screen and window geometries
can not be trusted for comparison before window
geometries have been adjusted properly
BUG: 404500
FIXED-IN: 5.15.2
Test Plan: check that global menu still works properly
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19126
Summary:
--when the user has enabled PLASMA_USE_QT_SCALING
under X11 environment the screen and window geometries
can not be trusted for comparison. In such case
the global menu should be always visible
BUG: 404500
Test Plan: check that global menu still works properly
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19126
Summary: Is a smaller library and provides everything we need
Reviewers: apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19066
Summary:
KSMServer has two modes, the slightly ancient mode (XSMP), and the
really ancient legacy mode (XSM).
When startup was rewritten in 96a595f1b8
we accidentally dropped the call that invokes restore of the legacy
session as well as the normal mode.
BUG: 404318
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19028
Summary: Service is DBus activated, we don't want to manually restore it.
Test Plan: Code is copied directly from plasmashell
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19026
In 12h system locales (eg: en_US), checked=1 is cast as
Qt::PartiallyChecked=1 which defaults to the system locale (12h).
Since it's no longer a tri-state button, the user can't select
Qt::Checked=2 which forces the 24h state.
BUG: 404292
FIXED-IN: 5.15.1
Summary:
This patch adds the buttons Suspend, Restart, and Shut Down to the username prompt screen that appears once the Type User button is clicked so the user is able to suspend/restart/shut down from that screen without having to return to the initial login screen.
It also replaces the "Back" button with "List Users" (and an appropriate icon) on account of the latter being a more accurate description of what the screen goes back to once the button is clicked (and in case of future improvements, enables it to become a standalone login screen as well).
Test Plan:
Before: {F6605023}
After: {F6605026}
Reviewers: #vdg, #plasma, filipf, davidedmundson, ngraham
Reviewed By: #vdg, #plasma, filipf, davidedmundson, ngraham
Subscribers: abetts, davidedmundson, ngraham, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18893
Doing this on startup can easily add up to 20ms startup time for every icon pointing to a file.
It is not an issue with application links that don't have open with actions fortunately.
Differential Revision: https://phabricator.kde.org/D18925
I got "#define HAVE_X11 TRUE" and errors because of that where #if was
used.
This also obeys the logic that HAVE_X11 is set (in the toplevel
CMakeLists.txt) not only when X11_FOUND but also when XCB is found.