ToolButton should not be used in shared component since it's clints
might have different representation.
Instead, make the component have no visual representation at all,
delegating it to clients themselves.
Without this, the virtual keyboard appears and takes focus, which
doesn't make sense:the password field needs to retain focus or else
the keystrokes you type using the virtual keyboard get eaten.
BUG: 430209
FIXED-IN: 5.21
In commit 45e0a722fb we changed the focus
on the textfield with the intention of fixing the cusor blinking.
This had the unfortunate side effect of breaking waking out of the
screensaver mode with just the keyboard.
That screensaver mode was bound to:
```
property bool blockUI: mainBlock.mainPasswordBox.text.length > 0
```
for that to change, we need to have focus.
Instead this patches cursor blinking more explicity.
Doing it only in the lock screen (as opposed to the toolkit) makes sense
as this only happens due to somewhat unusual usage inside the
lockscreen.
BUG: 431286
An opacity of 0 but still visible still results in nodes in the
scenegraph, which is wasteful. This is shown in gammaray with some
warnings.
Enabled is also bound to visible as if a text field has focus it still
animates the cursor icon even if inivisble, producing wakeups.
BUG: 347772
FIXED-IN: 5.21
there was a behavioral change in qtvirtualkeyboard, where now it
reparents itself to the root item (done by purpose to make sure is
always on top of any overlay), not respecting the parent's geometry
so move it in the kwyboard widget itself
BUG:427934
Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
Commit bcaf3886 removed the property `m` in UserDelegate.qml, but it is still used by
`userListCurrentModelData` in SessionManagementScreen.qml at least.
This broke switching to an existing session via the "Switch User" button on the lock screen or the
application launcher/menu, it just hung with an empty screen and this runtime error in the logs:
file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml:444: TypeError: Cannot read property 'vtNumber' of undefined
Adding it back makes switching work again (and gets rid of the runtime error).
CCBUG: 423526
FIXED-IN: 5.20.3
The old code took a pointer to an opaque object then tried to find
matching properties.
Use of aliases makes things clearer. It should also help if someone adds
a property to OSDItem again.
- Increase the size of next/previous media toolbuttons. I didn't think there was enough padding around the buttons here.
- Set a default width and height of LockScreen.qml. This makes it start with a sane default size when run with qmlscene.
Some users reported this button becoming too small after KF5.74 was released, but I could not reproduce it myself. However, this code did look suspicious. Hopefully this fixes the issue.
Simplifies the logic of the busy indicator since now it will already
fade out when it's not running.
Also addresses the logic of the timer which was off.
This made krunner freak out on Wayland for some reason to investigate,
both opacity animations were triggering a repaint and we tried to render
too often making the process block. With this change it works fine
again.
"Show" vs "Show always" is technically precise, but awkward in practice,
and I don't think the distinction is helpful. People are accustomed to
media controls appearing on demand, so I think we can safely put it in a
group with the label "Show".
There were three principal sources of errors and warnings:
1. Un-ported `onFooChanged` statements
2. `config.fontSize` being unconditionally referenced from components
without access to it (it comes from the SDDM config)
3. Accessing units from the context property rather than the singleton
All are fixed now. Tested with:
1. `sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/`
2. `~/kde/usr/lib64/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel`
3. `/kde/usr/lib64/libexec/ksmserver-logout-greeter --fakearg`
No regressions found.
BUG: 425349
FIXED-IN: 5.20
This was previously done in the component itself, but that was removed
in 711789908b0c6c0f76597596d567fba4ae9151ca (plasma-framework). For the
most part, buttons look better without the old minimum width, but these
buttons here relied on that behavior and do in fact look better with it.
So let's set it manually on these buttons.
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
On the lockscreen or on a single user system you can currently move the user
item horizontally across the screen without it doing anything. If the list only
contains one entry, disable interacting with it.
We've now made it easier to increase the maximum volume to 150% for
those who need it due to quiet speakers. However since this could
potentially lead to excessive volume or damage to loud speakers with
long-term use, let's colorize the text to subtly indicate that this is
not a normal state.
The volume setting in plasma-pa can exceed 100%. Currently the display is limited to 100%, which can result in a mismatch between what is shown in the applet and in the OSD.
This adds an overload to volumeChanged to keep the old one compatible given it is used by e.g. kmix
Andrey Butirsky
l10n daemon script
Nate Graham
David Edmundson
Kai Uwe Broulik
Alexander Lohnau
Cyril Rossi
Marco Martin
Konrad Materka
Wolfgang Bauer
Aleix Pol
Carson Black
Noah Davis
Niccolò Venerandi
David Redondo
Yuri Chornoivan
Nicolas Fella