Summary:
Makes the API more complex, but it's worth it as it allows
knowledgable users to opt into avoding costly work and/or
data copies in very common use cases.
Significantly speeds up a lot of work in the models in the
presence of X apps that can't be identified and fall back to
the window icon.
Based on profiling by David.
Reviewers: dfaure, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1920
We are told the start and end date but we didn't actually add the event to the other days.
BUG: 364345
Differential Revision: https://phabricator.kde.org/D1891
Summary: Second half of the merge of the functionality found in Netrunner's EITM fork.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1895
"new KRun" is only meant to run absolute file paths and so breaks when we get a
service with relative entryPath() like when finding a KCModule.
The tempFile argument causes this call to be asynchronous as to not block the UI
Summary:
qDeleteAll will iterate through containments() however this is
dynamically changing the list we're iterating through.
Particularly bad is deleting the panel might delete the system tray
containment, leading to a double delete on a now dangly pointer.
Test Plan: kquitapp5 plasmashell. No crash
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1890
Rather than showing the generic calendar icon the day number is shown there instead.
There is also an option to have it show the week number instead.
FIXED-IN: 5.7.0
BUG: 343467
Differential Revision: https://phabricator.kde.org/D1867
There's no point in loading a massive album art (I've seen music files having
sizes of up to 1500x1500) just to show it scaled down again.
Also changes the binding from playerCombo.visible to playerCombo.count so it doesn't
change the sourceSize causing a reload of the image whenever the applet gets hidden/shown
since visible propagates recursively
Summary:
On Wayland we need special glue code to make KWin aware of the position
the DesktopView wants to be. This change ensures that DesktopView calls
setPosition on the PlasmaShellSurface on creation and whenever the screen
geometry changes.
With this change DesktopViews are properly positioned in a multi-screen
setup on Wayland.
Reviewers: #plasma_on_wayland
Subscribers: plasma-devel
Tags: #plasma_on_wayland
Differential Revision: https://phabricator.kde.org/D1889
Summary:
When grouping inline, the group subtrees are flattened out into
the top-level list, parents removed, and move() treats groups as
singular entities.
This functionality was previously found in Netrunner's Expanding
Icons Task Manager fork.
This is the first half of the EITM functionality merge.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1881
We only show the "Remove this applet" option when the panel controller is opened
to prevent the user from accidentally messing up his setup.
However, the "Remove this panel" option, albeit in a submenu, was always there and
is even more destructive.
BUG: 360300
Differential Revision: https://phabricator.kde.org/D1869
The check was supposed to check whether kinit would start and exit otherwise.
By adding the qdbus call inbetween, it would check for that one instead and if
no ksplash was running the exit code would be non zero aborting startup.
Differential Revision: https://phabricator.kde.org/D1888
When rendering SVGs through Image you need to provide a sourceSize.
This sourceSize needs to be scaled with device pixel ratio to ensure crisp rendering.
Use the Plasma blue gradient and remove the dark gray background.
Also get rid of the sliding animation and just fade in instead, makes for a much
more calm experience.
Reviewed-By: David Edmundson
This is a part from yet another new login screen design which I find much nicer.
It's pretty late in the cycle so let's just only add the new clock and then
do the rest later.
Also minute align the clock data engine and only poll every 60s instead of every second
This is to match the new design of the login and splash screen.
We're a bit late in the release cycle for this so we'll just change the wallpaper
and do the proper new design later.
Reviewed-By: David Edmundson
Summary:
This also allows to only emit launcherCountChanged() when it actually changed.
The emit from TasksModel::filterAcceptsRow() is weird though.
Test Plan:
adding one launcher for dolphin, shows up. Running dolphin,
the launcher disappears. Switching desktops, it reappears. Coming back, it
disappears. Closing dolphin, the launcher reappears.
Reviewers: hein
Reviewed By: hein
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1865
When you click an item it might show a menu of some sort which will grab the mouse
and the ToolTipArea never gets a leave event causing the tooltip to show up above
the menu.
Differential Revision: https://phabricator.kde.org/D1847
As suggested by fellow developers, they usually want the backtrace right away.
To use this feature add ShowOnlyBacktrace=true in the [General] section of ~/.config/drkonqirc
There'll also be a GUI option in kdebugsettings
Differential Revision: https://phabricator.kde.org/D1832
Summary:
We want to drop workspace code from KDED as it doesn't make much sense
semantically.
This patch ignores the messages from kded, so that they can be dropped
in a future frameworks release and introduces a new signal sent from
startkde.
This puts all workspace related code in workspace.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1859
Summary:
We use QT_SCREEN_SCALE_FACTORS as opposed to QT_SCALE_FACTOR as we need
to use one that will *NOT* scale logical DPI according to the scale.
Scaling the fonts makes sense if you don't also set a logical DPI
manually, but we need to do that for both PlasmaShell which does it's
own thing, and for KDE4/GTK2 applications.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1849
when the containment (or an applet in it)
gains the state Plasma::AcceptingInputStatus
force the focus to the panel window, restoring
the behavior of Plasma4
BUG: 364276
Eike Hein
Alexander Potashev
David Edmundson
Kai Uwe Broulik
David Faure
andreas kainz
Martin Gräßlin
Friedrich W. H. Kossebau
Daniel Vrátil
Marco Martin
Hrvoje Senjan
Luca Beltrame