Summary: Otherwise the build fails when things try to link to KF5::SysGuard etc.
Test Plan: Builds again
Reviewers: #plasma, meven
Reviewed By: meven
Subscribers: meven, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29628
Summary:
In some rare situations SNI icons are not rendered. It happens randomly, only some users are affected. It does not happen on every login.
Only SNI icons are not rendered, Plasmoids are fine. Restarting plasmashell or re-adding systemtray applet helps.
In QML all roles need to be defined before model is used. When data engines is used a a source for a data model, all roles has to be defined and proper value assigned (not a null QVariant). StatusNotifierItemSource does this properly, but in some situations it sets null QVariant for Icon. Setting empty/null QVariant removes key/role from the date set (DataConteiner implementation). If data model was loaded earlier or later when Icon has proper value it will work properly. In some rare situation it is possible that data model is loaded when Icon has null value assigned (in other words - removed), role is removed from the data model and not avaiable to system tray applet.
This fix makes sure that there is always a value for Icon role. To check if icon is null native method has to be used - QML does not understand that QIcon can be null.
BUG: 419305
FIXED-IN: 5.18.5
Test Plan: I don't have any reliable method to reproduce this issue.
Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29386
Summary:
Is there a better way to report error from this code than the dialog box
that KRun used to pop up (and KDialogJobUiDelegate does too)?
Test Plan: Untested.
Reviewers: davidedmundson, sitter, broulik
Reviewed By: broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28988
Summary:
plasma.kde.org doesn't exist anymore and causes the appstream test to
to fail.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27304
Summary:
ContainmentActions had some old windows code was dropped as that's
clearly unused.
logout and leave actions now enable/disable at runtime, so in future can
respond to config changes when that's added to libkworkspace.
DataEngines and the krunner code should have no visible changes
Test Plan:
Left from the desktop and from krunner
Changed the default action in ksmserver's kcm
Confirmed that changes the default leave action changed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21764
Plasma Browser Integration provides controls for Chrome, so when a player with kde:pid metadata is found, it is preferred over the actual pid it represents.
Differential Revision: https://phabricator.kde.org/D26702
Summary:
Use QQC2.Slider, so that we have a moved signal. This way we can only
issue new brightnesses when the user actually interacts with it.
Don't adapt to the system brightness until we have finished interacting
with it.
Test Plan:
Manual testing, flickering is very much reduced both when scrolling over the
compact plasmoid as well as the slider.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26035
Summary:
Adding support for Attention Icon to StatusNotifier tray icons.
Binding is working correctly only when "Status" is used, not derived "status".
BUG: 341255
Test Plan: As described in bug report, Konversation can be used for tests.
Reviewers: #plasma, broulik, #plasma_workspaces
Reviewed By: #plasma, broulik, #plasma_workspaces
Subscribers: lbeltrame, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24865
Summary:
Right now windy conditions are not handled at all. I live in an area with very frequent
windy conditions especially during certain times of year so this is annoying because I
see the purple question mark icon a lot, which in the past has made me stop using the
weather widget.
This patch implements handling for windy + clear and cloudy conditions for NOAA. I
don't know how to implement this for Wettercom.
Depends on D24537
Test Plan:
Before: {F7568603}
After: {F7568554}
Reviewers: kossebau, #plasma, spstarr
Reviewed By: #plasma, spstarr
Subscribers: spstarr, plasma-devel, #vdg
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24483
Summary: Include duplication, no newline at the end of file and missing argument to the i18n() call
Test Plan: Should work fine but needs a review for i18n() calls
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24580
Arjen Hiemstra
Konrad Materka
David Faure
l10n daemon script
David Edmundson
Ahmad Samir
Heiko Becker
Yuri Chornoivan
Kai Uwe Broulik
Antonio Rojas
Aleix Pol
Méven Car
Laurent Montel
Jonathan Riddell
Nate Graham