Summary: Currently, there was some code to avoid system tray resizing. However, being the properties not set to the root element, this was not having any effect. This fixes it.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29824
This enables some basic grouping when pointing a list at the group parents instead of the individual child elements.
Effectively unused right now (popups don't group and history only shows the application name for sections)
but this is in preparation for being able to have groups in the popup as well.
Differential Revision: https://phabricator.kde.org/D27130
Depending on font size and settings the ProgressBar's implicit size might be wider
than our minimum size of 15 gridUnit. This causes the Popup to change size when switching
from ProgressBar (e.g. changing volume) to Text (e.g. volume muted).
By setting preferredWidth to 1 we ensure we never exceed the overall minimum size
when the ProgressBar is shown.
Summary:
Hiding the old menu after the new menu is shown isn't possible on Wayland:
```
qt.qpa.wayland: setGrabPopup called with a parent, QtWaylandClient::QWaylandXdgSurface(0x17dd550) which does not match the current topmost grabbing popup, QtWaylandClient::QWaylandXdgSurface(0x120d9f0) According to the xdg-shell protocol, this is not allowed. The wayland QPA plugin is currently handling it by setting the parent to the topmost grabbing popup. Note, however, that this may cause positioning errors and popups closing unxpectedly because xdg-shell mandate that child popups close before parents
```
Test Plan:
Before, Wayland: Trying to open a menu under Wayland while one is already open fails.
After, Wayland: Trying to open a menu under Wayland while one is already open succeeds.
Ensure no regressions on X11.
Reviewers: #plasma, #kwin, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29464
Summary: The appmenu applet now accurately replicates the hover behaviour of a regular menubar.
Test Plan:
Before: you need to click to engage all menus.
After: the appmenu applet copies the behaviour of a QMenuBar when it comes to clicks and hovers.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29465
Summary:
A frequent complaint over the years is the size of the OSD. It was tried to alleviate that by having it start fading out slowly immediately but the way it was done wasn't ideal, didn't work on Wayland, and also causes flickering issues in recent Qt versions.
This changes the OSD to a bar-like design similar to the one used in Plasma 4.
BUG: 344393
BUG: 372665
FIXED-IN: 5.20.0
Depends on D29263
Test Plan:
Various OSD messages
{F6773939}
It can grow, if necccessary, to accomodate translations, up to half the screen width.
With Air theme
{F6773940}
Full desktop screenshot for some context
{F6773941}
Reviewers: #plasma, #vdg, broulik, niccolove, ndavis
Reviewed By: #vdg, niccolove, ndavis
Subscribers: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D20569
Summary:
Otherwise we're discarding style information possibly set in
the user's small font choices when we want to set a smaller
font.
Test Plan: Stuff that's suposta look small still looks small
Reviewers: cblack, #plasma
Reviewed By: cblack, #plasma
Subscribers: ahiemstra, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29437
Summary:
In D29652, I made an annoying mistake: I removed the check if the clipboard is empty when initializing the **Plasmoid.status** of the Clipboard applet. If the user enables the option to save clipboard content, then after restarting the Plasma, even if the clipboard had content, the state of the applet will be **PlasmaCore.Types.PassiveStatus** and its icon will be hidden in the system tray. This patch fixes this issue. I hope it will get into Plasma 5.19.
See: https://phabricator.kde.org/D29652
Reviewers: ngraham, mart
Reviewed By: ngraham, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29818
Summary:
CCBUG: 417836
Depends on D29711
As this will depend on Frameworks 5.71, it will be landed on master after branching,
ending up in Plasma 5.20.
Test Plan:
Right-click on applets and activate their configure menu items
Open applets and click on their settings buttons
Observe that the KCMs are opened in System Settings or Info Center
(depending on the context)
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29712
Notification spec says, when replacing a notification:
> The server must atomically (ie with no flicker or other visual cues) replace the given notification with this one.
Notifications shifting about is a "visual cue".
Differential Revision: https://phabricator.kde.org/D29771
Test Plan:
Open the Application Launcher, right click any app -> Add to Panel (Widget),
then click the icon on the panel, it should launch.
Reviewers: #plasma, broulik, dfaure
Reviewed By: dfaure
Subscribers: dfaure, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29687
This refactors the free space notifier module to use a critical (i.e. persistent and always on top) notification for warning of low disk space.
The, albeit blinking, tray icon is easy to miss, especially when you're running a full screen terminal, which I typically do while compiling stuff.
It now also monitors the Root folder, if it's on a separate partition from the user's home. Furthermore, Filelight is offered to explore the drive (if installed).
The overall warning logic remains pretty much the same:
* Once the drive goes below the configured threshold a warning notification is shown, it stays on screen until dismissed by the user or
when free space is above warning threshold again.
* The notification is emitted again when free space drops below half the previous threshold, for added sense of urgency should the drive
be rapidly filled up
* The notification is also emitted again if free space remains below the threshold for more than one hour
(It will only emit again when it was closed, obviously, so you won't end up with a tonne of popups after a few hours ;)
I don't think this needs to be separately configurable for Home and Root, since the default threshold is like 200 MiB (it's not a configured
percentage), so the absolute free space it warns about will be the same, even if your Home is giant compared to Root.
BUG: 340582
FIXED-IN: 5.20.0
Differential Revision: https://phabricator.kde.org/D29770
Fixes regression caused by me meddling with data in 6e660cf92d
Unfortunately KRunner has no notion of "this is application xyz" so Kicker has to make assumptions, which broke here.
Differential Revision: https://phabricator.kde.org/D29744
Summary:
It would be correct to close the Clipboard applet after clearing the history or deleting the last element, since there is nothing more to do with the empty Clipboard applet (similar to how the Notification applet closes after the last notification is removed).
BUG: 421345
FIXED-IN: 5.20
Reviewers: ngraham, #plasma, broulik
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29652
Summary:
Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal.
Comments in other code say that "OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" so this patch replaces it with NumberAnimation.
There's also a minor fix included - placing the drop shadow sooner in the hierarchy because it should be drawn underneath an object, not in front of it.
Test Plan:
Reduce the fadeout time to something small and then:
`sddm-greeter --test-mode --theme /usr/share/sddm/themes/breeze`
Reviewers: ngraham, cblack, #plasma, mart
Reviewed By: ngraham, #plasma, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29351
Summary:
Duplicate function calls to load the config in the runner/config have been removed.
The actions of the runner are also refactored, similar to https://phabricator.kde.org/D3688.
Also the user (owner of process) has been removed from the subtext, because the second line is not shown and adding the user info to the same line would be too long.
Test Plan: Should compile and kill processes as before.
Reviewers: davidedmundson, ngraham, broulik, meven, apol
Reviewed By: meven
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27513
It only had a return value for "NoCharge" since the else case was only for not plugged in, resulting in it effectively returning undefined,
throwing during assignment "cannot assign [undefined] to string" and leaving whatever text happened to be shown last.
BUG: 420920
Differential Revision: https://phabricator.kde.org/D29633
WatchedNotificationsModel is a unstable API and does not provide any
API/ABI gurantee, look and feel developers or application developers
should not use this API for time being.
Summary:
When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.
BUG: 421344
Reviewers: ngraham, plasma-devel, broulik
Reviewed By: ngraham, broulik
Subscribers: broulik
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29651
Summary:
If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.
Test Plan:
* Set NeedsAttention as a status and with no Attention Icon
* Base Icon should render correctly
Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, mart
Reviewed By: #plasma_workspaces, #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29544
Summary: Otherwise the build fails when things try to link to KF5::SysGuard etc.
Test Plan: Builds again
Reviewers: #plasma, meven
Reviewed By: meven
Subscribers: meven, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29628
Summary:
Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
Makes it easier to test combinations of those.
Reviewers: kmaterka, apol
Reviewed By: kmaterka, apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29619
Summary:
Those plasmoids are intended to replace the old systemmonitor plasmoids
They are based upon the new ksysguard daemon: see D28333 and D28141
It has pluggable presets and sensor "faces" which are available from the KDE store
Every preset is available as a separate plasmoid.
By default are installed ones to replace
roughly one by one the existing systemmonitor plasmoids so systems that use it
will get the new ones in the updates
Depends on D28922
Test Plan: {F8209642}
Reviewers: #plasma
Subscribers: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28487
Niccolò Venerandi
Kai Uwe Broulik
Nate Graham
Carson Black
Eugene Popov
Ahmad Samir
Laurent Montel
Jonathan Riddell
l10n daemon script
Marco Martin
Filip Fila
Alexander Lohnau
Bhushan Shah
Konrad Materka
Arjen Hiemstra
David Redondo