Replace KWebView with QTextBrowser in unhandled bugzilla error dialog.
KWebView is not used to load a page here, it is just used to display
HTML with setHtml (without baseUrl) so any external URLs (stylesheets,
images, ...) are not resolved.
Replacing it with QTextBrowser should provide similar rendering.
REVIEW: 125886
By the time the activated signal is fired, currentIndex has not been updated yet, at least
when selecting ComboBox entries by mouse. When using the mouse wheel it works, which is
probably why I haven't noticed the breakage.
CHANGELOG: Fixed changing applet visibility in system tray settings when clicking the options
With the change to the QuickViewSharedEngine, it seems to load synchronously, meaning the
status changed slot is never called and when I broke my lockscreen I locked myself out
in the process.
REVIEW: 125848
Otherwise ensureWindowType calls winId, triggering a window creation and
since the geometry is rect(0,0,0,0), the view is moved to the screen that
contains 0,0.
BUG: 353975
Currently we're hitting a bug where the panel won't be displayed in the
correct position because of how the screen it's in is computed. See:
https://codereview.qt-project.org/#/c/139533/
This patch makes sure there's no off-by-1 issues by placing the screen
initially at the center.
This migrates the Lock Screen qml from using ksmserver's Session model
to the new one provided by components.
Changes:
- It now shows the user avatar and full name in the user switcher
- It only offers to switch sessions if there are any
REVIEW: 125774
This switch is rarely used and screenlocker is important part of the
Plasma system. So it makes no sense to have it build-disabled by ifdef
Reviewed by: Martin Gräßlin
This work around was ifdef'd with COMPILE_SCREEN_LOCKER but since
config-ksmserver.h was never included this code never got compiled.
Reviewed-By: Martin Gräßlin
This makes specifying absolute paths on the commandline that are then
encoded into the config file work.
Not hard-coding the packackage prefix is also helpful on a multiarch
layout where the prefix is /usr/${host} but arch-independent files
should still be installed to /usr/share (i.e a level below the
prefix).
REVIEW: 125844
setLock was used to tell kdm not to re-auto-login if session is in
crash-restart loop. However given there is no kdm not it serves no use.
Only use was in ksld and was removed in dcdb990e38
Reviewed-By: d_ed
From the KDisplayManager code :
// This only tells KDM to not auto-re-login upon session crash
void
KDisplayManager::setLock(bool on)
{
if (DMType == NewKDM || DMType == OldKDM)
exec(on ? "lock\n" : "unlock\n");
}
Given we no longer have kdm in Plasma 5. This hardly makes sense.
REVIEW: 125837
This reverts commit 5674a757c9 which was
pushed without review and is not correct.
Please stop pushing code without reviews.
CCMAIL: xiangzhai83@gmail.com
Currently X11Locker highly depends upon the X specific parts and doesn't
work on the wayland. This WaylandLocker class is default implementation
for the AbstractLocker and currently no-op.
This commit also adds the guards for X specific code in KSldApp so it
don't crash on the wayland platform
REVIEW: 125827
added some formfactor keywords in the applets metadata.
once the explorer model filters them accordingly,
it should remove a bit of applets problematic on
the phone for one reason or another
REVIEW:125810
We seem to have a problem in the autotest concerning grabbing so
try to make the whole thing less timing dependent.
The XSync should be before the server grab, otherwise it just doesn't
make sense. And all XLib code should do a flush as otherwise we don't
know if that will happen at all.
This unittest verifies that the emergency window is shown by verifying
- There is at least one white and one black pixel
- There is no other colored pixel then black and white
Reviewed-By: Martin Gräßlin