We do this sometimes, but not consistenly.
The benefit is twofold.
First it improves the diff when adding new values since no existing line needs to be touched.
Second it prevents clang-format from collapsing the definition into a single line, which is undesired for large enums.
Summary:
Each notification was created as new datasource, and was newer removed
as long as the engine exists. This is especially bad for long living
applets like the device notifier. As there can only be one notification
per device (the last error state, or none), use the UDI as source name
and update the contents.
Also cancel (remove source) an old notifications in case of a successful
setup, otherwise old error messages are shown in the device notifier.
Test Plan:
in Dolphin, select "Release" (context menu) for a mounted CD
-> Notification in device notifier appears "Device can be safely removed"
remount without ejecting
-> Notification message is removed, device shows "mounted" emblem.
Without the change, the message stayed and the device kept the notification
emblem "(!)".
Reviewers: #frameworks, broulik
Reviewed By: broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15892
Instead of showing a detached status bar with the device name, show the message
below the device in the list.
When removing a device, device notifier will pop up and a "You can now safely remove
this device" message will show up with a highlight gradually fading away until 5 seconds
later the device is removed from the list.
REVIEW: 126688
Alexander Lohnau
Adrien Faveraux
Ahmad Samir
Nicolas Fella
Stefan Brüns
Friedrich W. H. Kossebau
Kai Uwe Broulik
Igor Poboiko
Lukáš Tinkl