Makes it look better (no empty gap) and given you can change brightness using keyboard
shortcuts and mouse wheel, the looks outweigh the additional mouse travel
BUG: 336708
FIXED-IN: 5.1
The parent item has opacity == 0.8, which means both the preview icon
and the actual preview are sligtly transparent and the icon bleeds
through; let's hide it completely
BUG: 339628
Reviewed-by: Bhushan Shah
Right now the clock applet is using one single label (besides the
sizehelper) to fit time, timezone and also date. This has several
drawbacks like for example the whole label must use one font size, one
eliding etc.
Putting everything into its own label gives way more flexibility as we
can position and size things independently - for example making the time
bigger font than the timezone or date and elide long timezone name
without omitting the date. The sizing is now also simpler and more
robust.
This patch adds the time and timezone labels into Flow which changes
direction based on the layout (in vertical panels layouts things
vertically, horizontal panels either vertically or horizontally
depending on date being shown or not), the date label is then always
appended at the bottom. The reason for dateLabel not being in the Flow
is that in horizontal panels we want the date label always go to the
bottom and be center aligned and Flow does not support horizontal
alignment of its children. Two anchors seems much easier in this case.
This removes two i18n strings and works around having to add another one
(line 352 in the patch) - it's not kosher but I did it so it can still
be merged for 5.1.
Finally, this adds states for separate handling of vertical and
horizontal panels, which has cleaned the code quite a lot from all the
"vertical ? complex_a_stuff : complex_b_stuff".
REVIEW: 120461
This prevents file:///usr/share/plasma/look-and-
feel/org.kde.breeze.desktop/contents/osd/Osd.qml:93:20: Unable to assign
QString to double
BUG: 339581
needed for center and right alignments
now 90% of the times the behavior of the panel controller is correct.
but problems still happen
CCBUG:339202
CCBUG:339207
needed for center and right alignments
now 90% of the times the behavior of the panel controller is correct.
but problems still happen
CCBUG:339202
CCBUG:339207
This allows the theme to decide it does not want us to just show a battery frame
and then add the individual fill pieces but to provide a different battery for
every fill. The current Breeze theme does this by providing a red Fill20 and Fill0
and to prevent superimposing a full red battery ontop of a black one, the Battery svg
can have this item which hides the battery frame.
If a theme decides to manipulate the looks of the "empty battery",
like the current Breeze theme does by painting it red, it can now
provide a Fill0 svg. If it is not present, the old behavior, showing
just the battery "frame" that is, remains.
Kai Uwe Broulik
Martin Klapetek
Marco Martin
l10n daemon script
Andrew Lake
Elias Probst
David Edmundson
Jeremy Whiting
Hrvoje Senjan