And comment out the qDebug() calls (the ones without a logging category),
useful for debugging but they spam the terminal output if you e.g. start
systemsettings from terminal.
Also don't print time with debug statements, useful for benchmarking, but
too much output in terminal otherwise.
GIT_SILENT
This is now done on the frameworks side using the X-Plasma-Runner-Unique-Results
property and the id of the matches. Consequently we can drop this workaround.
The min letter count property is set to 3, which means that shorter queries will not be
sent to the runner. Consequently we can remove all of the code which has worked around
the issue of short queries taking much CPU power and delaying the runner.
powerdevil expects the brightness to be in absolute values not
percentages.
I know this is a blocking call, but we use QDBusInterfaces and
other blocking calls in here so it's not great but is a reasonable
fix for now.
BUG: 437408
The current KRunner utility methods have some issues:
- The runner id is kindof useless, especially when we only have one
action
- We basically create a bunch of temporaries whenever we use the utility
methods
- If one really has more actions and more complex logic one is better of
using QHash with the actions and an enum as the key
This saves us the custom implementation of mimeDataForMatch and
allows us to get the urls for example in milou, just like we already can
with the DBus runners.
This is also what a lot of other runners do, with such short
queries the user does not get many useful results or they are
immediately removed if additional letters get typed.
- Use constant values instead of parameter if value is always the same
- Define lambda to add new test, this works around
https://bugs.llvm.org/show_bug.cgi?id=45018 and gives useful hints in an
IDE
Add explicit find_package() and #include's that are required and were
pulled in by KDELibs4Support.
krdb: remove one redundant #include, KColorUtils
kcm_fonts: send dbus message directly to org.kde.KDEPlatformTheme to
'refreshFonts'
kcm_style:
- use KToolBar::emitToolbarStyleChanged() to notify of toolbar style changes
For the rest use the notifyKcmChange() private method to send the dbus
signal.
[1] https://invent.kde.org/frameworks/kdelibs4support/-/blob/master/src/kdeui/kglobalsettings.cpp#L860
The test should make sure the chrome bookmarks and profile reading
works properly and not test the conversion logic.
In the previous commit a dedicated test has been added
for the conversion and relevance logic.
Adrien Faveraux
Nicolas Fella
Ahmad Samir
l10n daemon script
Alexander Lohnau
Felipe Kinoshita
David Redondo
Peter Hoeg