Otherwise it enters an infinite loop where the DesktopView starts to be
moved from a screen to another. That happens on XCB (only platform I've
tested) because setScreen and setGeometry will send an XCB event that is
later processed by the application again.
This should probably backported to Plasma/5.4, but considering I'm running
Qt 5.6 I would really appreciate it if someone can check if it works for
him and cherry-pick it there. An easy way to test is to change the primary
screen (in a 2-screen set up) using the kcm or xrandr.
CCMAIL: plasma-devel@kde.org
Libtaskmanager so far only has compile time checks for windowing
systems resulting in the X11 specific code to be executed on platform
wayland which of course causes crashers.
This is a workaround by at least ensuring that we only call X11 specific
code on platform X11.
REVIEW: 125445
The test aborted because it had code executed before the QGuiApplication
was created which needs a QGuiApplication. The fix is to delay the
initialization into initTestCase.
By grabbing the XServer we can ensure that no other client is
sending X events. This eliminates a possible timing attack in
the time frame between grabbing keyboard and pointer.
At the same time the waiting and try again becomes useless as the
XServer is grabbed and no other client could release the hold
input device grab.
REVIEW: 122528
taking colors for the svg and text from ColorScope makes it work
on the inverted areas, such as the plasma mobile top bar.
disable the text selection by mouse on mobile as well
the config buttons to configure each individual notification
As suggested by the VDG, add the possibility to have screenshots for plasmoids.
the widget explorer will be modified as well to show the screenshots
in the applet list when available
REVIEW:125134
/bin/sh stops execution upon finding a nonzero exit code,
which means that startkde will not continue if a script in
.config/plasma-workspace/env/ produces an error.
This small fix will execute a no-op in such a case,
so that errors will not affect startkde's progress,
while still being visible in .xsession-errors.
REVIEW: 125323
BUG: 352491
This is a follow-up to fbd4a876, which introduced an option to
have running tasks always use the same icon that would be used
for a launcher item. The Task Manager applets subsequently were
updated to default this option to on, addressing frequent user
complaints that Task Manager launchers don't respect their
theming choices (due to window icons overriding the icon theme,
or custom configured icons) or that the icon changes when a
launcher item is replaced by a running task item.
However, for windows that can't be mapped back to an application
known to the menu system, this meant falling back to the MIME
type of the executable, making applications that aren't properly
installed usually end up with application-x-executable or some-
thing else.
This commit changes behavior so that if the launcher URL pro-
duced for a window isn't a valid KService storage id, the window
icon is used again. In turn, since the behavior is now no longer
a trivial yes or no, the option has been dropped from the
library again, making the menu-icon-takes-precedence approach
always-on. In turn, if a launcher item is generated while a
window is around, the icon is taken from the window and stored
persistently. If a launcher is added programmatically using an
URL that can't be mapped to the menu, the icon will be updated
from the window icon at runtime.
BUG:351624
CCMAIL:jkt@kde.org
At the moment we update the clock when we resume from suspend or from
the time KCM.
However the signal from the clock KCM isn't very good as it signals just
after it requests an NTP update or clock change, not necessarily when
that finishes.
Also we miss any external NTP updates which might occur at other times
throughout the day, such as a big change when we connect to the network
This method also avoids needing solid to tell us when we're resuming
from suspend, which is deprecated API and also seems slightly slower.
BUG: 344870
REVIEW: 125028
On my system I faced the problem that instead of my prefix installed
ksmserver, the system installed ksmserver was started by kwrapper5.
REVIEW: 125113