Summary:
When clicking the hide button provided by the virtual keyboard, the
keyboard hides, but the state is not updated. This means the animation
for hide is not triggered and even more important the next call to
showHide sets a wrong state. The state assumes it is in visible, when
clicking it goes to hidden. So the virtual keyboard is not getting shown
when clicking the show virtual keyboard button.
To address this problem a change handler for keyboardActive is added
which ensures the state is correct whenever the keyboardActive value
changes.
BUG: 381833
FIXED-IN: 5.10.4
Reviewers: #plasma, sitter
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6456
The structure was only freed in case the XTest method was chosen.
But it should always be freed of course (as long as it isn't NULL).
Use a QScopedPointer instead to free it automatically when it goes out
of scope and to be more consistent with the rest of t
Differential Revision: https://phabricator.kde.org/D6389
Summary:
Also better sanity-checking of found services being app services
all around.
I'm not particularly happy about adding more X11 code outside of
XWindowTasksModel, but it means greater code reuse (in something that
has experienced unwelcome drift before) and there's a precedent in
LauncherTasksModel.
Reviewers: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6358
Summary:
Otherwise we:
* ... don't get startup notifications.
BUG:381500
* ... don't contribute data to recent/most used apps.
This is a surprisingly large oversight.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6354
Since Qt 5.8 for some reason the Connections {} on plasmoid.nativeInterface breaks.
BUG: 375535
FIXED-IN: 5.10.3
Differential Revision: https://phabricator.kde.org/D6335
Signals did not get changed for Qt5 porting but no one ever noticed because
they were still in stringy runtime eval syntax :S
Using proper signals to connect to fixes attaching a new backtrace to
an existing bug.
Backport of fix from D6161.
CHANGELOG: Make attaching backtraces to existing bug reports work
Check the return value of xcb_get_window_attributes_reply() to prevent a crash if getting the window attributes would fail for some reason.
Also free the returned structure after usage to avoid memleaks.
This is necessary according to https://xcb.freedesktop.org/windowcontextandmanipulation (see the end of the page).
Differential Revision: https://phabricator.kde.org/D6252
We used to always delete the backing .desktop file if we changed a property in a Link (to
a document) hoping that setUrl would call populate. However, it won't do that if the URL
didn't change, so if you only changed the icon, the .desktop file was removed and never
re-created, breaking the applet.
BUG: 380922
FIXED-IN: 5.10.2
Differential Revision: https://phabricator.kde.org/D6148
Label has verticalAlignment: lineCount > 1 ? Text.AlignTop :
Text.AlignVCenter
but in this delegate the height stretches to fit the text:
- height depends on verticalAlignment
- lineCount depends on height
creating a loop with this in the middle.
In this case we always want delegates in the middle, so we can just
override the superclass.
Summary:
The lockscreen uses the MPRIS dataengine. This leads to two applications
registring the service using the same component name which leads to the
shortcuts not working when the lock screen closes.
We want to have the applet register the shortcuts, but not every
dataengine user.
Ideally this shouldn't be in the dataengine either because DataEngines
are read only. This moves the logic to the service which is writable and
registers the shortcuts for the multiplexer there when requested from
the applet.
BUG: 380526
FIXED-IN: 5.10.1
Test Plan:
Opened media player.
Used play/pause shortcut. (the only one my keyboard has)
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6100
Because of C++'s operator precedence, '!' logically negated
all_event_masks only instead of the whole expression.
This resulted in the condition always being false and XTest never being
used.
Adding a pair of brackets fixes it.
BUG: 362941
BUG: 375017
FIXED-IN: 5.10.1
Differential Revision: https://phabricator.kde.org/D6048
Summary:
Otherwise if we show the plasma-nm applet twice, m_sensors won't be empty
and we won't be able to fect the connection speed data.
git blame points to
ba7444f99a
and
235fea1868
but they don't really explain why setData() was called only if m_sensors
was empty.
BUG: 380209
Test Plan:
- plasmoidviewer -a org.kde.plasma.networkmanagement
- open the networkmanager applet twice
- make sure the connection's speed graph works the 2nd time.
Reviewers: #plasma, jgrulich
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5973
Summary:
In Plasma we install a DBus activated service to handle the case of
notifications being sent before Plasma is loaded. This file clashes with
other notification daemons and causes distro issues.
The convention is to make this file name match the DBus service name so
that we can detect conflicts, however in this case we know we have an
unavoidable conflict, but it doesn't really have an repurcisions other
than the user having an undetermined notification daemon chosen during
plasma bootup (which was the case before this patch too)
Effectively it's the same problem we have with the
org.freedesktop.FileManager1 service and Dolphin, and the same solution.
Test Plan:
Installed this
kquitapp5 plasmashell
notify-send some message. Confirmed it waited
started plasmashell. Got the message
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5968
Summary:
The pinned launchers that are assigned to other activities
will have a -1 as the order. We should not forget them
when saving to the configuration file.
Reviewers: hein, mart
Reviewed By: hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5933
if any kscreen related activities occurred
during startup, the panel wouldn't be visible
yet, and this would assert. This often happens
when a screen gets disabled at startup
CCBUG:377280
Martin Flöser
Jonathan Riddell
Wolfgang Bauer
l10n daemon script
Eike Hein
Kai Uwe Broulik
Harald Sitter
David Edmundson
Aleix Pol
Marco Martin
Elvis Angelaccio
Ivan Čukić
Friedrich W. H. Kossebau