Summary:
We need Local to be *always* present, even if not disaplayed as
it's used for formatting in ToolTip.dateTimeChanged()
this makes sure local is always in the connected sources, even if
it's not explicitly shown to the user
Test Plan:
tested, local timezone is not shown in clock/tooltip when
selected, and no warnings from dateTimeChanged()
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2936
Summary:
We need Local to be *always* present, even if not disaplayed as
it's used for formatting in ToolTip.dateTimeChanged()
this makes sure local is always in the connected sources, even if
it's not explicitly shown to the user
Test Plan:
tested, local timezone is not shown in clock/tooltip when
selected, and no warnings from dateTimeChanged()
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2936
Summary: Correct misleading debug output. Make all ksmserver output (apart from
the tests) controllable with QLoggingCategory.
Test Plan: Compiled, logged in and out both with & without
"ksmserver.debug=true" in qtlogging.ini
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2935
$qdbus is a full path to the qdbus binary, not relying on it being in
$PATH
It was completely unset in startplasma and startkde made a call to
ksplash using qdbus assuming it's in the path
Reviewed-by: David Edmundson
Summary: we can start launching ksmserver in the meantime
Test Plan: Logged in
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2910
Summary:
migrate the enabled runners from enabledCategories
to the more classic [Plugins] group
the krunner framework supports both, so as long
the enabledCategories entry isn't there,
it will work correctly with the other config format
Test Plan: ran on an existing krunnerrc with different sets of categories enabled, tested krunner and its kcm with it, all expected runner plugins were used both in the kcm and while searching with krunner
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2873
Summary:
on first startup all the desktop views already exist after the
script has been executed, so check the screen doesn't already have
a view for that screen before creating one
BUG:368891
Test Plan: tested both first and subsequent startups, one desktopview per screen created, containment config dialog coming up (and only one of them)
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2885
Summary:
KCMInit is loaded early in startkde, and it blocks all other processes
from starting until it is complete.
This can be up to 1.1 seconds.
(http://imgh.us/bootchart-20160928-1316.svg)
A sizable amount of time (46% of CPU) is spent loading our QPT. This
isn't very useful given none of the kcm_init scripts have any UI and
it's not something they should have. It's only a QGuiApplication so that
they have an X connection.
Test Plan: Checked it ran without errors
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2882
Summary:
Renamed userPrompt to userPromptComponent and add an id
(userListComponent) to the initialItem Login component.
Disable user list when there are too many users in the system
In sddm 0.14, there's a userModel.disableAvatarsThreshold property
that defines how many users are "too many" in the system so loading of
avatars should be disabled. This commit honors that property, so if
there are more than disableAvatarsThreshold users, then the user list
is disabled and a prompt is shown to ask for a username and password.
If the property is not available (for example, because sddm 0.13 is
being used) then it works as usual.
This threshold is specially useful for large enterprises with NFS
automounted home directories. In such environments, using sddm while
avatars are enabled results in all remote home directories being
mounted in the system before one user is able to log in. This has been
reported to take hours in cases with thousands of users.
By default the threshold has a value of 7, but it can be modified
in sddm.conf, under the Theme section, in the
UsersThresholdToDisableAvatars variable.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2874
Summary:
The default wallpaper method is to scale the wallpaper, and the previous
algorithm in plasma choosed the wallpaper with closest area to the screen
area (w*h) giving a bit of preference to downscaling over upscaling.
The result was that in widescreens like 1280x720, a 1280x1024 wallpaper
was preferred to be scaled down, instead of scaling down the also
available 1920x1080 wallpaper, which had the same aspect ratio and so,
was not distorted.
This patch changes the Image::findPreferedImageInPackage method to do the
same closest-area algorithm first on wallpapers with the same
aspect ratio and if no wallpaper with same aspect ratio is found, then
fallback to the previous algorithm. Note I added some variables so both
happen in the same loop and we don't have to iterate twice
over the wallpapers.
This fixes https://bugzilla.opensuse.org/show_bug.cgi?id=990257
Test Plan:
Make sure the wallpaper mode is in Scale. Choose a wallpaper with
1920x1080 and 1280x1024 resolutions which shows a perfect circle,
a recognizable object or a face. Then change the screen resolution to
1280x720. The wallpaper should appear with correct aspect ratio.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2834
when a panel is created it doesn't have a view immediately,
so we have to work around by writing its config instead.
we have to force lastScreen of the newly created containment,
or it won't have a screen yet at that point, breaking JS code
that relies on it
NOTE: if we'll allow setting a panel screen from JS,
it will have to use the following lines as well
not creating the panel view yet in order to have the same code path
between the first and subsequent plasma starts.
we want to have the panel appearing only when its layout is completed, to not have
many visible relayouts. otherwise we had even panel resizes at startup that
made al lthe full representations be loaded.
reviewed-by: David Edmundson