Solid's UDisks backend never emits the Solid::OpticalDrive::ejectPressed signal.
It is only present in HAL whereas Linux uses UDev these days.
Differential Revision: https://phabricator.kde.org/D13752
Summary:
This change allows users to scroll through krunner output using their homerow.
- Ctrl+j: Scroll Down
- Ctrl+k: Scroll Up
This makes scrolling easier for those familiar with this convention but doesn't inhibit users who aren't.
Reviewers: broulik, #plasma_workspaces, davidedmundson
Reviewed By: #plasma_workspaces, davidedmundson
Subscribers: davidedmundson, #plasma_workspaces, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13686
Summary:
On X, this is entirely useless.There's a special code path in create for
windowType == Desktop and in ::setGeometry it doesn't seem to help/hinder.
It's not like we need WM_NORMAL_HINTS for a WM to resize us.
On wayland it's downright destructive.
On the second setGeometry call the QPA bounds the new geography to the
current min/max (from our previous screenGeometryChanged). But updating
the min/max doesn't update our geometry. End result is our screen is
off.
Test Plan:
Resized screen on Wayland. Wallpaper now filled exactly instead of being broken
Resized screen on Xcb. Wallpaper still filled the screen precisely
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13850
KFilePlacesModel internally only stores search:/ URLs and then translates them to the correct Baloo query as needed.
Differential Revision: https://phabricator.kde.org/D13841
The codepath for opening devices was never actually entered as always a QUrl was set as data.
This resulted in errors like "Cannot open URL /org/freedesktop/someudi".
Moreover, for some reason the run() code created a new KFilePlacesModel but since devices are added delayed,
searching for a device in the model right after creation doesn't work.
The code is adjusted to use the one KFilePlacesModel instance in the helper, since run() is executed on the main thread anyway.
Differential Revision: https://phabricator.kde.org/D13840
Summary:
This makes the list items draggable.
To do this, the backend model was split up into three models so
the move() method could actually move a row as the new drag handle
expects. This also makes move and remove actions a little bit
faster since there's no proxy abstractions involved. The use of
Plasma.SortFilterModel with JS callbacks for filtering has been
dropped from the QML code.
The lists now use DelegateRecycler to be speedier.
The list of available languages is now guaranteed to be sorted in
a locale-aware manner and case-insensitively, using QCollator.
This likely works better than whatever PSFM was doing with the
Qt::DisplayRole sort role before.
Also drops a stray unused KConfigGroup member from
TranslationsModel.
Reviewers: mart, davidedmundson
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13194
Summary:
When the applet is on a vertical panel, its horizontal size is limited, and the speedLabel clashes with the name label. I fixed that by moving the speed values below the sensor name in this case.
I also added some cleanups unintentionally (the first three hunks), as I couldn't find a way to change the diff after it's submitted. They remove an unneeded import, and fix some uninitialized variable warnings. Feel free to ignore them.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12857
Summary:
Port plasma desktop scripting to qjsengine, removing every trace of QScript from plasma-workspace.
The scripting is 100% API compatible.
the bindings are partly done on the javascript part as some things are only possible there and not on the QJSEngine part:
* setting AppInterface as the globalobject's __proto__ with property getters that are evaluated every time
* setting functions that act as constructors (using newQMetaObject gives way more complex and uglier c++ code in Containment, as the scriptengine is not immediately accessible)
* a QRectF wrapper which exposes all properties and methods that were exposed in the previous implementation
Test Plan:
* some manual api test from the interactive console
* tested both from the desktop console and first start with some pretty complex layouts from lnf packages (the default one, netrunner, united, elpas)
* tested every property/methos of the qrectf wrapper
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13112
Which delegates the task of doing it to a out of process IO slave and makes it asynchronous.
KDiskFreeSpaceInfo blocks querying mount points and might freeze for a while with NFS stuff.
Differential Revision: https://phabricator.kde.org/D13350
They are usually hidden for a reason and shouldn't show up in the slideshow.
BUG: 394882
FIXED-IN: 5.12.6
Differential Revision: https://phabricator.kde.org/D13260