Summary:
Fixes regression from the startkde C++ re-write which made ksmserver
start the kscreenlocker in wayland session, resulting in the double
lockscreeens.
Test Plan: after applying patch I only get one lockscreen
Reviewers: apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22021
Summary: without dbus-run-session developer can't login into this session
Test Plan: now login works
Reviewers: apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22020
Summary:
D19852 intrdouced x-kde-force-image-copy hint for programs to specify that
images should be set to the clipboard even if should not be included in the
history. But when the program was closed the clipboard was restored to the first
item in history in which the image was not included. To fix this introduce a new
class member which holds the last clipboard item and restore it.
Credit goes to David Edumndson
Test Plan:
Try it with spectacle
Reviewers:
@ngraham, @davidedmundson, #plasma
Subscribers:
Summary: Creates the necessary files in the build directory as well as provide a script that will install them to /usr so the login manager can find it.
Reviewers: ngraham, #plasma, hein
Reviewed By: ngraham, #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21992
Summary:
If this entry is not added, kpackagetool5 tries to load the specific
packagestructure plugin, fails to load it and then writes the metainfo
as it is "application" instead of add-on
Reviewers: apol, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21991
Summary:
GIMP 2.10 is still being a bad desktop citizen and requires a workaround
of this sort as well.
A nicer fix to do at a later time would be a regex-based rewriting rule
that won't need version updates.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21954
Summary:
GIMP 2.10 is still being a bad desktop citizen and requires a workaround
of this sort as well.
A nicer fix to do at a later time would be a regex-based rewriting rule
that won't need version updates.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21954
Look and feel stuff is loaded into various other places so it needs to set a domain explicitly
CHANGELOG: Media controls on the lock screen are now properly translated
Differential Revision: https://phabricator.kde.org/D21947
Summary:
Forking and printing a PID gains nothing.
The new startplasma script tracks the process used to start ksplash
itself.
BUG: 380495
Test Plan:
Logged in, saw a splash
Ran the test from systemsettings, saw a splash
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21890
Summary:
QActionGroup has no signal for when an action within the group changes
checked state. Only when an action within is triggered.
Without calling trigger InteractiveConsole::modeSelectionChanged is not
triggered and m_mode is not updated.
BUG: 408787
Test Plan:
qdbus to launch the console
Execute button went to the right place
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21852
This is a similar situation we have with Flatpak when the desktop entry the application thinks it owns is actually different.
In Snap this environment variable is passed to the process. When no service was found, try reading it.
CHANGELOG: Improved notification identification for Snap applications
Differential Revision: https://phabricator.kde.org/D21881
Summary:
Currently, the default configuration of showing all individual cores is pretty useless on system with a high number of cores.
This changes the default to only show all individual cores on systems with 8 cores or less, on systems with more cores only the total cpu usage is shown
Reviewers: #plasma, #vdg, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21690
Summary:
With Plasma dialogs & tooltips the mask is only set on the widget itself
if compositing is off. Instead is the mask explicitly passed for the
KWindowEffects.
The recent changes to fix the blurbehind & contrast mask with panels
instead turned to always set the mask on the widget. For some reason
yet to be understood this can sometimes result in an offset by a pixel
between the mask used for painting and the mask used for the window effects.
Aligning the mask setting code with the one for dialogs & tooltips makes
the symptom go away for now, and also delivers consistency.
BBUG: 406380
FIXED-IN: 5.16.1
Test Plan:
Using different themes, including Adapta & Arc Dark, a gap can no longer
been seen. Only with compositing turned off, which is old behaviour due to
the real bug yet to understand completly.
Resizing panels or changing screen resolution also works without breaking
rendering or panel contents interaction.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21803
Summary:
The session selector's and keyboard layout's menus are now styled to resemble the Breeze theme rather than the default QML style.
BUG: 408702
Test Plan: Ensure the styling looks good regardless of various conditions. (resolution, dpi, distro, amount of sessions, etc.)
Reviewers: #vdg, filipf
Reviewed By: #vdg, filipf
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21794
Summary:
At the moment we had several scripts to start the different processes. With this we unify this code into an application that takes care of the whole process.
This allows us to:
- Save on process spawning, we don't need to run a separate process synchronously for every single thing.
- Don't have a redundant configuration file parser but reuse the one we've already optimised in KConfig.
- Issue dbus calls from the process itself instead of spawning qdbus.
- Removes a bunch of duplicated code.
Test Plan: Started different systems on different distros, on wayland and x11.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21725
When an application got renamed by flatpak-builder without knowing it, it will still send its original value as desktop-entry breaking the mapping and settings.
CHANGELOG: Improved notification identification for Flatpak applications
Differential Revision: https://phabricator.kde.org/D21779
Summary:
ksmserver's loading of other window manager relies on files in
share/windowmanagers/$name.desktop with the Exec line of the window
manager.
This was something previously installed by plasma-desktop and removed in
2016. All this code path is now redundant as well as the wmChanged DBus
method used by the deleted KCM.
Setting KDEWM manually will still work as before.
Test Plan:
Logged in
Got kwin as before
Reviewers: #plasma, broulik, apol
Reviewed By: #plasma, broulik, apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21758
Summary:
We don't support multi X screen anymore in the rest of plasma. Cleans up
a bit of code.
Having multiple monitors via xrandr will still work as before.
Test Plan: Compiles
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21757
Summary:
this engine is not used anywhere!
the engine used kfilemetadata to obtain metadata of a file. KFM however
is entirely defunct and does absolutely nothing without nepomuk.
that is to say: it is already broken for years and in fact not even
correctly sets the item.type key because of how the original code worked.
this change drops the kfilemetdata use altogether and instead sets the
item.type (which we can easily determine) to file when working with a file
in theory (I think) Baloo/File is the modern replacement for kfilemetadata,
but its properties are no longer "stringy" so we'd have to map a huge
enum manually into stringy keys for our representation. which at this time
seems not worth it, considering we (KDE) do not seem to use the engine
anymore and third parties would have had an entirely broken engine WRT file
sources as well, so I am guessing no one outside KDE uses it either.
all things considered I think simply rolling the engine back to the
minimum functional use is the best course of action here.
this effectively only changes the engine behavior to once again set
item.type=file on actual files while making it no longer require
kdelibs4support.
Test Plan:
in engine explorer requesting a directory gives unaltered directory data,
when requesting a file it correctly sets the type to file
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21765
Summary:
kde4_add_app_icon is fairly deprecated. additionally the call itself
was madness because it actually pulls the icon out of oxygen in the install
location. that is assuming the icon theme is even installed at build time
(which is probably always not true in our binary factorization
environments). lastly the app_icon helper is only useful to pick up
icons for osx and windows, neither are target platforms for plasma.
remove the app_icon call entirely until a use for it arises, which should
be... never... unless we decide that we want to replace explorer.exe ;)
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21766
Bhushan Shah
l10n daemon script
David Redondo
Aleix Pol
Méven Car
Eike Hein
Kai Uwe Broulik
David Edmundson
Jonathan Riddell
Vlad Zagorodniy
Robin Appelman
Nate Graham
Friedrich W. H. Kossebau
Filip Fila
Carson Black
Luca Beltrame
Harald Sitter
Laurent Montel