The setting was supposed to be disabled when global menu service was unavailable.
However, the service is now autostarted based on whether there is a global menu "view" available.
The property got removed but forgotten here.
Differential Revision: https://phabricator.kde.org/D16149
Adds a MouseArea so it opens on press like QMenu does.
It just forward to clicked since this is called from various places (keyboard nav, Alt activation, etc)
Differential Revision: https://phabricator.kde.org/D13108
This reverts commit e37156b404.
Concept is fine, but currently we have severe CMake issues as well
as a major containment loading bug.
When re-reverting we need to be sure to test with clean install prefixes.
CC: plasma-devel@kde.org
Summary:
The "Encoding" entry had been deprecated in 2006
(https://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36)
and there is no current workspace known which still requires it being set
(incl. Plasma itself).
Also has the usage been incomplete and sometimes not at the beginning as
required if used (once scripty had sorted all entries in desktop files
alphabetically and it was not restored everywhere).
Removing them altogether creates consistency and avoids further confusion
about and wasted resources for this unused data bit.
Removing those entries also from Plasma/5.12 branch avoid conflicts on
merging to master, given the entries are often next to translated entries,
or generous merging which lets the entries slip back into existance.
Reviewers: #plasma, fvogt, broulik, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11563
Summary: use the new install macro which compresses packages in a bundled rcc
Test Plan: tried to load and use every single plasmoids
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11514
Always redirect to the ones in m_menu in case they get deleted or otherwise altered.
Also emit dataChanged when an action changes and reset the model when it gets deleted.
This fixes the menu getting confused in LibreOffice 6 with gmenu-dbusmenu-proxy.
CCBUG: 391868
Differential Revision: https://phabricator.kde.org/D11350
Applications could place actions in the main menu bar that do not have a menu.
Also restore the checked binding when clicked to avoid it highlighting even though there is no menu.
This might also fix some spurious highlighting that I've seen when switching between windows.
Differential Revision: https://phabricator.kde.org/D11168
Summary:
--add NeedsAttention status when a menu is showing, and
Passive status when the menu is not available
--remove status updates from plasmoid interface
Test Plan:
I used debug messages to confirm the status changes and
also Latte to check that dynamic background now works ok
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10710
Summary:
-- hiding a menu shouldnt initialize the currentIndex to -1
at all cases. When a secondary menu is already shown then
the currentIndex should be only the index of the new menu.
This improves also the qml bindings because currentIndex
doesnt change all the time with no reason.
Test Plan:
added debug messages in qml side to check the value of
currentIndex
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10695
This makes for a less cluttered appearance and is what Breeze does by default.
BUG: 389118
FIXED-IN: 5.13.0
Differential Revision: https://phabricator.kde.org/D9948
In case the application sets the menu after the window is shown like is the case with Firefox.
Differential Revision: https://phabricator.kde.org/D9635