When a device notification arrives, such as "you can now safely unmount" or "failed to unmount"
device notifier would unconditionally open showing an empty list.
Since we now show device notifications only connected to the device they're about, it makes no
sense to expand it for invisible devices. Applications where mounting or unmounting can fail
for non-removable devices, like Dolphin, already show the error message within the UI anyway,
making the popup redundant.
BUG: 368894
FIXED-IN: 5.8.0
Differential Revision: https://phabricator.kde.org/D2823
Device auto-mounting is quite related to the device notifier and we used to have
that in Plasma 4 but lost this setting there as we cannot embed widget UIs into
plasmoid configuration dialogs.
BUG: 364977
FIXED-IN: 5.8.0
Differential revision: https://phabricator.kde.org/D2060
Instead of having a bunch of handlers in various places messing with various settings,
try to use declarative bindings where possible.
* Remove separate passive timer, instead re-use the pendingDelegateRemoval property
which has its own timer. This way, when a device is unmounted, device notifier stays
active until the notification has cleared, however, when the device is yanked out manually,
it disappears right away
* Don't break binding on Plasmoid.active to ensure its state is always proper depending on
whether a device or not is present (the linked bug)
* Create tooltip declaratively rather than imperatively
BUG: 362992
FIXED-IN: 5.7.0
Differential Revision: https://phabricator.kde.org/D1793
The emblem-mounted is not supposed to be used for an action. It worked fine with
Oxygen where it looked like a plug but doesn't with Breeze.
BUG: 358875
FIXED-IN: 5.7.0
Instead of showing a detached status bar with the device name, show the message
below the device in the list.
When removing a device, device notifier will pop up and a "You can now safely remove
this device" message will show up with a highlight gradually fading away until 5 seconds
later the device is removed from the list.
REVIEW: 126688
The code is from a time before we had smart layouts and thus is pretty complicated
with lots of anchoring. This cleans up the code massively.
The layout is a bit tighter now, the eject/mount button is now a proper ToolButton.
The "n actions for this device" text now disappears when the actions are expanded;
(dis)appearance of the disk usage bar is now nicely animated, while the lagging behind
hover effet has been removed.
REVIEW: 126673
- Battery and device notifier go into Hardware category
- Clipboard goes to SystemServices category
- Notifications and media controller go to ApplicationStatus category
The popup opening by itself is attention enough; more importantly that status never
seems to be unset properly (States anyone?) causing the icon to blink, and eating CPU
indefinitely
get the mounted state using the dedicated isMounted(udi) function;
this allows to simply eject e.g. an Audio CD which can't be mounted otherwise.
Also remove the action icon from an MTP player, it doesn't make sense
there and is non-functional anyway (one cannot mount/unmount it)
- Remove redundand "Available devices" label and only show "No devices available" if there aren't any
- Use the same Heading as the notifications for the sections
REVIEW: 119720
behavior from plasma1: the engine has an "added" value in devices
if false, means the device was already there when plasma started
therefore the applet shouldn't expand itself
this should fix the systray annoyingly opening
itself on each plasma startup
Kai Uwe Broulik
Marco Martin
andreas kainz
l10n daemon script
David Edmundson
Yoann Laissus
Jan Grulich
Lukáš Tinkl
Sebastian Kügler