[Device Notifier] Only ever pop up if device is visible in the list

When a device notification arrives, such as "you can now safely unmount" or "failed to unmount"
device notifier would unconditionally open showing an empty list.

Since we now show device notifications only connected to the device they're about, it makes no
sense to expand it for invisible devices. Applications where mounting or unmounting can fail
for non-removable devices, like Dolphin, already show the error message within the UI anyway,
making the popup redundant.

BUG: 368894
FIXED-IN: 5.8.0

Differential Revision: https://phabricator.kde.org/D2823

applets/devicenotifier/package/contents/ui/devicenotifier.qml

@@ -134,13 +134,21 @@ Item {
             processLastDevice(false);
         }
 
+        function isViableDevice(udi) {
+            if (devicesType === "all") {
+                return true;
+            }
+
+            var device = data[udi];
+            return (devicesType === "removable" && device.Removable)
+                || (devicesType === "nonRemovable" && !device.Removable);
+        }
+
         function processLastDevice(expand) {
-            if (last != "") {
-                if (devicesType == "all" ||
-                    (devicesType == "removable" && data[last] && data[last]["Removable"] == true) ||
-                    (devicesType == "nonRemovable" && data[last] && data[last]["Removable"] == false)) {
-                    if (expand && hpSource.data[last]["added"]) {
-                        expandDevice(last)
+            if (last) {
+                if (isViableDevice(last)) {
+                    if (expand && hpSource.data[last].added) {
+                        expandDevice(last);
                     }
                     last = "";
                 }
@@ -181,7 +189,10 @@ Item {
         onDataChanged: {
             if (last) {
                 lastUdi = data[last].udi
-                plasmoid.expanded = true
+
+                if (sdSource.isViableDevice(lastUdi)) {
+                    plasmoid.expanded = true
+                }
             }
         }