When a device notification arrives, such as "you can now safely unmount" or "failed to unmount"
device notifier would unconditionally open showing an empty list.
Since we now show device notifications only connected to the device they're about, it makes no
sense to expand it for invisible devices. Applications where mounting or unmounting can fail
for non-removable devices, like Dolphin, already show the error message within the UI anyway,
making the popup redundant.
BUG: 368894
FIXED-IN: 5.8.0
Differential Revision: https://phabricator.kde.org/D2823
When there is already a config for a given plasmoid, reuse it
instead of creating a brand new plasmoid (having config groups
endlessy accumulating in the config file)
https://phabricator.kde.org/D2817
BUG:365618
BUG:365569
be able to destroy applets even when locked: delete their config
by hand.
Except in one case: when the applet gets automatically destroyed
by dbus activation do *not* clear the config, it should be
reused next time.
BUG:365618
BUG:365569
Summary:
An expanding spacer had it's minimum size set to the config.length
Allowing the panel to go from config size to infinite.
The problem is the panel length effectively defaults to the size the
spacer starts at (it gets set when we drag it into the right place)
meaning it starts off huge and can never shrink. This then leads to
applets being pushed off the panel.
We want it to be in expanding mode from 0 to config.length
and non expanding to ideally be a fixed width - though still probably
compress if it would otherwise mean the applets would overflow.
Setting the preferred size does all that implicitly; and also sets the
appropriate hint so you can have a spacer in a flexible width panel
correctly.
BUG: 352651
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2785
Summary:
Plasma::PluginLoader::self()->listAppletInfo(QString() is expensive, it
loads and parses every .desktop file individually. Twice.
The main offender is the defaultApplets property, which gets requested
multiple times from JS space, and we reparse the files every time.
Moving the work to the constructor solves that. This saves loading (on
my machine) ~900 desktop files.
Test Plan:
- wiped config, defaults appeared
- DBus activated still worked
- restore works as before
Running "time plasmashell" shows:
BEFORE:
plasmashell 4.01s user 0.46s system 87% cpu 5.116 total
plasmashell 4.01s user 0.54s system 74% cpu 6.124 total
AFTER:
plasmashell 3.17s user 0.42s system 68% cpu 5.259 total
plasmashell 3.18s user 0.46s system 81% cpu 4.475 total
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: mart, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2756
I slapped a console.time in there and it would show 1ms even on some
of the subsequent invocations, so while QML engine should do some
caching magic, calling it once is better anway.
Differential Revision: https://phabricator.kde.org/D2719
This limits the size of the notifications in the popup to 10 lines of text.
The limit was removed when it was changed to a TextEdit so text could be copied from it.
BUG: 361389
FIXED-IN: 5.8.0
This adds an entry to clear all notifications in the history.
The entry is only shown if there's actually notifications currently in the history.
BUG: 343686
FIXED-IN: 5.8.0
Differential Revision: https://phabricator.kde.org/D2383
This works around a bug or strange behavior in QtQuick Controls Slider where when
reducing the maximumValue, the value is clamped to it (ie. reduced to it) but when
increasing it again, it gets its old value back up until maximumValue.
Differential Revision: https://phabricator.kde.org/D2647
Summary:
Applet::destroy doesn't delete the applet from Containment::applets in
the same event. Potentially a dbus activated service being restarted can
be added in this time, causing us to try adding a new applet with the
same ID before the first object is deleted.
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2703
Summary:
Applet::destroy doesn't delete the applet from Containment::applets in
the same event. Potentially a dbus activated service being restarted can
be added in this time, causing us to try adding a new applet with the
same ID before the first object is deleted.
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2703
Summary:
on vertical panels the systray could get
stretched to a size taller than it should, getting
a lot of empty space
BUG:368146
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2645
Summary:
The clock in the vertical panel can't fit, it won't word wrap as the
clock is only one word long - so it needs to have a horizontalFit size
mode (without a minimum size) so that the text always fits without being
clipped.
This brings the vertical state in line with the horizontalSmall state
which also sets a minimumPointSize of 0.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2644
internalSystray is (for some reason) only set in Component.onCompleted.
This fixes the warning this causes.
Differential Revision: https://phabricator.kde.org/D2608
Summary:
Leave action is checking on canLockScreen to enable the action instead of Lock action.
Fix the mistake so now Lock action is checking for canLockScreen and Leave action not anymore.
Test Plan: Lock action is now checking for canLockScreen and Leave action not anymore.
Reviewers: #plasma, sebas
Reviewed By: #plasma, sebas
Subscribers: plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2529
Summary:
Leave action is checking on canLockScreen to enable the action instead of Lock action.
Fix the mistake so now Lock action is checking for canLockScreen and Leave action not anymore.
Test Plan: Lock action is now checking for canLockScreen and Leave action not anymore.
Reviewers: #plasma, sebas
Reviewed By: #plasma, sebas
Subscribers: plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2529
This flips the tooltip when using right-to-left languages
CHANGELOG: Digital clock tooltip is now mirrored when in right-to-left language
Differential Revision: https://phabricator.kde.org/D2421
Qt already did the right thing of moving the buttons to the left but the gradient did not follow.
Differential Revision: https://phabricator.kde.org/D2422
This flips the tooltip when using right-to-left languages
CHANGELOG: Digital clock tooltip is now mirrored when in right-to-left language
Differential Revision: https://phabricator.kde.org/D2421
If all system tray icons are visible the arrow would hide but the reserved
space for the system tray would not change leavnig a gap.
BUG: 365636
FIXED-IN: 5.7.4
Differential Revision: https://phabricator.kde.org/D2387
There was a conflict between adding a config option [1] in master and a
fix to crop to the icon size [2] in the 5.7 branch. I still need the
cropping on my vertical panel, otherwise the icons are insanely big.
[1] https://git.reviewboard.kde.org/r/128400/
[2] https://phabricator.kde.org/D2160
Reviewed-By-Over-IRC: Marco Martin <notmart@gmail.com>
BUG: 365394
As requested by Usability we'll assume a job finished successfully as the most likely case
and only keep the notification persistent in case of an error.
This makes dealing with files significantly less annoying.
Differential Revision: https://phabricator.kde.org/D2223
Kai Uwe Broulik
Marco Martin
David Edmundson
l10n daemon script
Jacopo De Simoi
Olivier Felt
Bhushan Shah
Jan Kundrát