Summary:
Add simple volume control to Media Controller applet. Volume can by changed by:
- mouse wheel on applet icon (3 % step), and
- new global shortcuts (5 % step, unbound by default).
There is no mute support currently (mpris interface does not have a mute method so we would have to keep
track of old volume).
BUG: 386588
Test Plan: Tested in daily use with Cantata and SMPlayer. There is no UI change.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, nicolasfella, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11021
Summary:
Fixes
[...]/NotificationDelegate.qml:51:26: Unable to assign [undefined] to int
by using the correct name of the enum value.
[...]/NotificationDelegate.qml:122:33: Unable to assign [undefined] to bool
by proper initialization of notification model data
Test Plan: No more warnings e.g. on notifications for new emails from akonadi.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11743
This reverts commit e37156b404.
Concept is fine, but currently we have severe CMake issues as well
as a major containment loading bug.
When re-reverting we need to be sure to test with clean install prefixes.
CC: plasma-devel@kde.org
Summary:
The "Encoding" entry had been deprecated in 2006
(https://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36)
and there is no current workspace known which still requires it being set
(incl. Plasma itself).
Also has the usage been incomplete and sometimes not at the beginning as
required if used (once scripty had sorted all entries in desktop files
alphabetically and it was not restored everywhere).
Removing them altogether creates consistency and avoids further confusion
about and wasted resources for this unused data bit.
Removing those entries also from Plasma/5.12 branch avoid conflicts on
merging to master, given the entries are often next to translated entries,
or generous merging which lets the entries slip back into existance.
Reviewers: #plasma, fvogt, broulik, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11563
Summary:
Currently it always passes the top left corner of the SNI icon as coordinates,
but now it passes the actual click coordinates.
They can be outside of the icon's bounds (for instance if you click on the
label in the expanded tray), but they are converted to global coordinates
anyway.
Test Plan:
Now the context menu drawn by the application properly follows the
cursor.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11600
Summary:
Those had no transient parent set, so they got displayed somewhere, most of the
time on the wrong screen.
Test Plan:
Works fine for spotify and kteatime now, but certain applications
which trigger a LayoutChanged signal on the opened event have a Y offset.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11584
Summary:
Appending an empty array of actions to QQmlListModel triggers an assert
in Qt when built in debug mode, see https://codereview.qt-project.org/#/c/223985/
for details.
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: davidedmundson, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11519
Summary: use the new install macro which compresses packages in a bundled rcc
Test Plan: tried to load and use every single plasmoids
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11514
Always redirect to the ones in m_menu in case they get deleted or otherwise altered.
Also emit dataChanged when an action changes and reset the model when it gets deleted.
This fixes the menu getting confused in LibreOffice 6 with gmenu-dbusmenu-proxy.
CCBUG: 391868
Differential Revision: https://phabricator.kde.org/D11350
When seeking isn't possible but the track duration is known, show a progress bar instead of showing nothing.
A progress bar is also much nicer than a disabled slider here as it's then meant as an indicator instead.
Differential Revision: https://phabricator.kde.org/D11356
With shared QML engine this would affect all applets and since we properly escape HTML in notifications now this is unneccessary.
Differential Revision: https://phabricator.kde.org/D11109
Summary:
Adds a button in the plasmoid header to clear the history, same as the context menu.
The icon used is the same as clear history in the klipper plasmoid.
BUG: 386068
FIXED-IN: 5.13.0
Test Plan: Please test the alignment on your screen, whilst I made sure to use provided units, due to the indentation of heading I had to use fractions, which might lead to odd results on different resolutions / dpi
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11261
Applications could place actions in the main menu bar that do not have a menu.
Also restore the checked binding when clicked to avoid it highlighting even though there is no menu.
This might also fix some spurious highlighting that I've seen when switching between windows.
Differential Revision: https://phabricator.kde.org/D11168
Summary:
As there are only a few QML files in the respective /ui subdir, having the
JS file in the same dir still provides good overview
Test Plan: Applets UI & Config still work as before
Reviewers: #plasma, mart, broulik, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11145
Summary:
Instead of using the action icons to indicate the current state use
the new media playback status icons.
This is an alternative solution to the problem that the mediacontroller applet
icon in the system tray and the play/pause controll in the player are always
the opposite.
While it is still the opposite icon there is now a slight visual difference
to show that these icons mean different things.
This is meant as a solution to the problem discussed in D10032.
{F5741436}
{F5741437}
Reviewers: #plasma, andreask, broulik
Reviewed By: #plasma, andreask, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11056
Summary:
Currently the media controller only works with MPRIS services which support
the PlayPause command. By the MPRIS spec this is an optional feature though.
While most players out there support this, the MPRIS support in Gwenview
currently worked on does not (would need some more rewrite of internals).
Which makes the Media controller applet and/or Gwenview look broken :)
To keep the current design with a central Play/Not Play button, this patch
changes its behaviour depending on the CanPause flag:
CanPause=true -> show either Play or Pause
CanPause=false -> show Play enabled/disabled
Reviewers: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10973
Summary:
when the device notifier pops up automatically, leave it open
if there is no user activity, if there is any, close after around
3 seconds. Suspend the countdown if the notifier window either has
focus or the mouse cursor is over it, leaving the user the time to
go interact. if it doesn't have focus and the mouse leaves, resume
the countdown
replaces D10591
Test Plan:
tested for a while in a real world usage, it behaves in a fairly natural
way
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10921
Summary:
this avoids some unwanted scene changes and speeds up the
first open a bit, also initialize the size of the dialog main item
so there is a resize less when the Dialog is first shown
Test Plan:
difference in show time is already visible, tough still not perfect,
something else needs to improve as well
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: apol, broulik, hein, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10692
Summary:
--add NeedsAttention status when a menu is showing, and
Passive status when the menu is not available
--remove status updates from plasmoid interface
Test Plan:
I used debug messages to confirm the status changes and
also Latte to check that dynamic background now works ok
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10710
The delegate is quite heavy with lots of seldom used items and opening the clipboard plasmoid takes a significant amount of time.
Differential Revision: https://phabricator.kde.org/D10557
Summary:
-- hiding a menu shouldnt initialize the currentIndex to -1
at all cases. When a secondary menu is already shown then
the currentIndex should be only the index of the new menu.
This improves also the qml bindings because currentIndex
doesnt change all the time with no reason.
Test Plan:
added debug messages in qml side to check the value of
currentIndex
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10695
Radek Hušek
l10n daemon script
Friedrich W. H. Kossebau
Kai Uwe Broulik
David Edmundson
Fabian Vogt
Daniel Vrátil
Marco Martin
Christian (Fuchs) Loosli
Laurent Montel
Roman Gilg
Michail Vourlakos