Summary:
BUG: 400549
FIXED-IN: 5.15.0
Test Plan:
On the lock screen KCM at 1.2x scale, before: {F6554037}
After: {F6554040}
All functionality continues to work on the lock screen and SDDM KCMs and desktop containment window.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18343
Summary: The current default setting is "Scaled", which results in images that don't match the screen's aspect ratio being compressed along the X or Y axis which almost never looks good. Cropping the image instead of deforming it is a much better default setting.
Test Plan:
- Create new user account
- Right-click on desktop > Configure Desktop
- See that "Scaled and Cropped" is the default setting for the Image and Slideshow plugins
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18004
Summary: No big visible changes, but simplifies and modernizes the code
Test Plan: used all functionality of the systray config dialog
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17212
org.kde.slideshow is duplicated at compile time, so translations aren't extracted for it.
Setting an explicit domain fixes that.
Differential Revision: https://phabricator.kde.org/D16037
Summary:
With slideshow desktop wallpaper plugin, selecting "Open wallpaper Image" from RMB does nothing. It looks like the `action_open` method called by the RMB menu action is using an old field that no longer exists.
The patch updates the code to use the correct field.
BUG: 394035
Reviewers: #plasma_workspaces, ngraham, broulik
Reviewed By: #plasma_workspaces, ngraham, broulik
Subscribers: broulik, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12777
Summary:
update the wallpaper dialog to the same design as the new KCMS
for consistency
Test Plan:
dialog loads with proper wallpaper selected, and both clicking on one
works and the attached toolbuttons work too
Reviewers: #plasma, #vdg, davidedmundson, broulik
Reviewed By: #plasma, broulik
Subscribers: davidedmundson, broulik, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12148
This broke in the transition to StackView as the blur needs a full-size source. Additionally
* put the item into a Loader to avoid needless shader compilation and other work
* only load the blur for image fill modes where the image does not cover the full size
* don't render background color when blur is enabled as you cannot see it anyway
Differential Revision: https://phabricator.kde.org/D11981
Summary:
The image wallpaper is a mess of 4 different fade functions, some not in
sync, and very complicated swapping images about.
This simplifies the whole thing by using a StackView, we just pop our
setup with a new configuration on and it handles deleting old objects
when the transition ends.
Code is 1/3 the size, whilst doing the same thing and should result in
having fewer items about.
In addition with this patch changing the transition effect in future
would be super trivial.
Test Plan:
Set as both image and wallpaper
Renders stuff as before
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11726
Summary:
The "Encoding" entry had been deprecated in 2006
(https://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36)
and there is no current workspace known which still requires it being set
(incl. Plasma itself).
Also has the usage been incomplete and sometimes not at the beginning as
required if used (once scripty had sorted all entries in desktop files
alphabetically and it was not restored everywhere).
Removing them altogether creates consistency and avoids further confusion
about and wasted resources for this unused data bit.
Removing those entries also from Plasma/5.12 branch avoid conflicts on
merging to master, given the entries are often next to translated entries,
or generous merging which lets the entries slip back into existance.
Reviewers: #plasma, fvogt, broulik, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11563
Summary:
The wallpaper loading code expects the catalogs to follow the pattern
"plasma_wallpaper_" + pluginid. While in config QML the domain needs
to be explicitly set using i18nd, as the default textdomain is set to
that of the config container, it is not needed in the wallpaper QML.
While using a catalog with plasma_applet_* prefix works if setting
the domain explicitly, the usage goes against the design of the
naming patterns. So to give a good example and also properly marking
the usage of the catalog, the names are switched.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10850
This avoids fading the image source, or the fill mode, or the source size on startup while we're still setting things up.
While a Timer is usually a bad idea, this simplifies the code a lot.
Differential Revision: https://phabricator.kde.org/D9762
The delete button changes the currentIndex to something else when deleting the current image but that didn't update cfg_Image.
Just listen to when we become current. Might also fix keyboard navigation (didn't test if that worked before but it certainly does now).
BUG: 388805
Differential Revision: https://phabricator.kde.org/D9818
Summary:
Related to patch https://phabricator.kde.org/D7047 . Pointed out by @ngraham
Make a new option called "Edge filling". Users can choose either "Blur image" or "Solid color". They are only visible when the image filling mode is "Center" or "Scale and keep ratio".
When it is "Center":
{F5447565}
When it is "Tile":
{F5447053}
Reviewers: ngraham, jensreuterberg
Reviewed By: ngraham, jensreuterberg
Subscribers: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8441
David Edmundson
l10n daemon script
Nate Graham
Marco Martin
Aleix Pol
Kai Uwe Broulik
Oded Arbel
Yuri Chornoivan
Friedrich W. H. Kossebau
David Edmundson
Guo Yunhe