Summary:
If having the need to use those settings with something else than the
default, one also expects the utils to follow those custom settings.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18625
Summary:
Setting an overlay by name results in a QIcon for it created; OTOH,
this icon is never used to create the final image in case the
main/attention icons are set by name too.
Since KIconEngine supports overlays natively, directly pass the list of
overlays (with just one element -- the overlay set) to it. As result,
main/attention icons by name are created directly with the requested
overlay by name.
Test Plan:
- builds fine
- main/attention icon by name + overlay by name works now, showing the requested overlay
- main/attention icon by name + overlay by pixmap still works as before
- main/attention icon by pixmap is unaffected, no matter whether/which overlay is set
- the system tray icons of juk, and amarok now have the play/pause overlays
Reviewers: apol
Reviewed By: apol
Subscribers: davidedmundson, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17983
Summary:
KCMs should have color icons while widgets should have monochrome icons, so I have changed the name of the KCM icon.
Depends on D18529
Reviewers: #vdg, #plasma, ngraham
Reviewed By: #vdg, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18532
Summary:
PlasmaVirtualDesktop at a protocol level is double buffered.
There's a done() command emitted after property changes. After this the
name might have changed.
Test Plan:
Changed a desktop name (with relevant kwin patch)
Name changed in the pager tooltip
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18512
Summary:
Ran into this gotcha the other day, and it was impossible to resolve
without code debugging.
Reviewers: #plasma, bshah
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18493
It's in the LNF components with identical contents.
It was forked here during porting to one of the new designs, then never
went away.
Differential Revision: https://phabricator.kde.org/D17920
Summary:
Before this patch if you had no active menu and configured your plasmoid
it would be invisible.
After this patch a placeholder is shown in that configuration.
BUG: 403232
Test Plan:
* Window with menu - menu shown, no placeholder (as before)
* Window without menu - state is hidden so nothing is shown (as before)
* Window with menu whilst configuring - menu shown (as before)
* Window without menu whilst configuring - placeholder shown (new)
* Compact represenation remains the same
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18481
Summary: setting an icon via i18n makes no sense
Test Plan: Put in vertical panel, had an icon
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18480
The desktop view isn't visible in the task bar, tabbox, and neither does it have a window decoration.
Differential Revision: https://phabricator.kde.org/D18430
Summary:
In the ksmserver porting most code was moved to explicitly calling
logout or shutdown methods rather than a random enum.
A legacy code path remained for compatibility. This path is used by the
containmentactions, in the refactor handling of
KWorkspace::ShutdownTypeDefault was lost.
BUG: 403466
Fixed-in: 5.15.0
Test Plan:
Set different default modes
Logged out using containment actions
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18435
Friedrich W. H. Kossebau
l10n daemon script
Pino Toscano
David Edmundson
Noah Davis
Eike Hein
David Edmundson
Kai Uwe Broulik
Nate Graham