Summary:
Code currently gets the applet interface object passed in explicitly,
from this it gets the configuration via the metaobject system
We always guard the appletConfig not being available, but never the
appletInterface, resulting in crashes if used from qmlscene or any
potential tests.
Test Plan: Used from qmlscene
Reviewers: #plasma, apol, hein
Reviewed By: #plasma, apol, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22818
Summary:
System Tray sends two "ContextMenu" events which breaks focus.
One is send on mouse pressed, second on mouse clicked. As a result
right click on the system tray icon causes focus to lock on the icon.
If later user clicks somewhere else event is send to the first icon.
BUG: 376277
BUG: 409768
FIXED-IN: 5.17.0
Test Plan:
The best to test with Skype for Linux with SNI bridge.
To reproduce:
* Right click on the Skype icon, click on menu item (can be Show Skype)
* Right click on any other icon in system tray (or even any other place on the panel)
* Skype menu will appear
After fix:
* Right click on the Skype icon, click on menu item (can be Show Skype)
* Right click on any other icon in system tray (or even any other place on the panel)
* Correct menu should show
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, apol, plasma-devel, #plasma_workspaces
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22804
Summary:
KSysGuard fetches everything you could possibly need from a process.
If we just need a name of a process, we can use the new KProcessList API
in KCoreAddons.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22327
When two screens overlap during e.g. a presentation, automatically enable do not disturb mode.
As per usual with automatic do not disturb, it can be overruled by unchecking the checkbox in the notification plasmoid
where it will be disabled until the screen configuration changes again and it still find a mirrored screen setup.
Differential Revision: https://phabricator.kde.org/D22856
Summary:
Without this patch, plasma-workspace fails to compile for me with the following error:
```
In file included from /home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/moc_windowsrunner.cpp:10,
from /home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/mocs_compilation.cpp:2:
/home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/../../../../../../src/plasma-workspace/runners/windows/windowsrunner.h:61:9: error: ‘QMutex’ does not name a type
61 | QMutex m_mutex;
| ^~~~~~
```
Test Plan: It compiles now
Reviewers: #plasma, aacid
Reviewed By: aacid
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22976
When switching to "unread" state, animate the bell icon.
It only animates for the transition to unread so you can see where it's going,
but not every time a notification comes in, as that would be annoying.
Differential Revision: https://phabricator.kde.org/D23044
Summary:
Text inside a small circle has a lot of problems with fitting in there
and being properly aligned.
Test Plan:
Breeze:
{F7180340, size=full}
Breeze (with D23019):
{F7178197, size=full}
Air:
{F7178312, size=full}
Oxygen:
{F7178315, size=full}
Reviewers: #vdg, #plasma, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23018
Summary: Currently, it uses `notification-disabled for a non-disabled state
Reviewers: #vdg, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23033
Summary:
Since shellManager was removed, we have a quite big regressions
of any other shell that isn't the desktop one not loading in any
way from SDDM, causing a big issue for plasma mobile or any shell
based on plasma mini shell, which we have several now not working
images based on.
this allows for a shell being configured in plasmarc
Test Plan: shell specified in plasmarc loaded, loads the desktop if not specified
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23031
Properties like Identity, SupportedUriSchemes, SupportedMimeTypes are mandatory.
Ignore the player if it's clearly violating the spec.
CHANGELOG: Players not compliant to MPRIS specification will no longer work with Media Controller applet.
Differential Revision: https://phabricator.kde.org/D22596
Summary:
Without this patch, plasma-workspace fails to compile for me with the following error:
```
In file included from /home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/moc_windowsrunner.cpp:10,
from /home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/mocs_compilation.cpp:2:
/home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/../../../../../../src/plasma-workspace/runners/windows/windowsrunner.h:61:9: error: ‘QMutex’ does not name a type
61 | QMutex m_mutex;
| ^~~~~~
```
Test Plan: It compiles now
Reviewers: #plasma, aacid
Reviewed By: aacid
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22976
Summary: Wait for the other process to unregister before starting the new one.
Test Plan: Reproduced the problem Noah mentioned and addressed it.
Subscribers: ndavis, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22945
Summary:
when plasma is starting up, there are no panel views yet
this means that if a thickness (or other values)
are written to the config file and then the resolution changes before
the panel view gets created, we'll have a view that will default
to 30 pixels regardless what the layout js file specified.
This makes the scripting only write to a [Default] group for resolution
dependent properties when panels are not actually present
when they are already there, interact directly with the view which is
the safest option.
the view will use whatever is in the defaults group as default if the
resolution dependent is there, and when a new value is set for a
resolution dependent one, also update the default, which will
be used when screen resolution changes, as new default value
Test Plan:
* With virtualbox, change resolution continuously when plasma is starting up
with an empty setup, panel is the expected size now, as opposed to 30
* Stop Plasma. Change Screen resoluton with plasma *not* running, to a resoluton
still "unknown" to plasmashellrc, then start plasma again. Now the thickness saved
in [Default] is picked, instead of the arbitrary 30
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22893
Summary: The corona needs to be closed earlier.
Test Plan: Now we don't hit the race-condition when closing
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22948
Summary:
Introduces a new prop and turns it off by default.
Also rewrites the initial "all applications" data gathering avoid
a crash uncovered while working on this (it didn't check EntryType)
and reduces assumptions about the model topology.
It also makes it collect root-level apps now, which was forgotten
to be added when support for root-level apps were added.
This supercedes D22762 and D22890. It does less duplicate work and fixes
more bugs while also not breaking the Dashboard UI.
Reviewers: #plasma, davidedmundson, tcanabrava
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22901
Summary:
When the notification count is in double digits, the numbers can overflow the icons which is meant to contain them.
This patch checks if there is more than 1 digit and then slightly reduces the size of the numbers.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22878
Summary:
We had an overly complex and in practice unexploited system to detect
which shell to use,
This patch changes it to default to the desktop, still allowing to
modify which to use from --shell-plugin argument.
Test Plan:
Starts up fine, --shell-plugin/-p still works, which is what
bhushan told me is important for plasma mobile.
Reviewers: #plasma, davidedmundson, bshah
Reviewed By: #plasma, davidedmundson, bshah
Subscribers: bshah, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22874
Since it is a custom `TextEdit` to make text selectable the workaround in the style didn't apply to it.
Differential Revision: https://phabricator.kde.org/D22858
Shawn Starr
David Edmundson
Konrad Materka
Christophe Giboudeaux
Marco Martin
Yuri Chornoivan
Kai Uwe Broulik
l10n daemon script
Filip Fila
Nate Graham
Noah Davis
Laurent Montel
Aleix Pol
Björn Feber
Eike Hein