Summary:
One thing that has been bugging me a bit with notifications is how close the pop-up is
to the screen corners/edges. It's so close that it obscures various things that live very
close to screen edges, such as windows' titlebars and the text input field in chat apps.
The latter case is really annoying in particular because if you have multiple chat apps
running, notifications from the app that's in the background will obscure what you're
typing in the text input field of the foreground chat app.
This patch fixes these types of issues by doing the following:
- Adjusting the popup positioning algorithm make popups that are in a corner equidistant from both adjacent screen edges, rather than only one
- Doubling the defualt distance from the nearest corner/edge
The combination of these changes allows pop-ups to no longer obscure window titlebars
and chat windows' input fields.
BUG: 401500
FIXED-IN: 5.16.5
Test Plan:
Top corner popup position no longer obscures window titlebar text and buttons: {F7259424}
Bottom corner popup position no longer obscures chat app's text input field: {F7259425}
Reviewers: broulik, #plasma, #vdg
Reviewed By: broulik, #plasma
Subscribers: cblack, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23253
Summary:
Wine is using XWindow Shape Extension for transparent tray icons.
We need to find first clickable point starting from top-left.
BUG: 399234
Test Plan:
Bug fix test:
1. Enable KWin compositing;
2. Download this test program (SHA-1: 63ae606aee64259091e7f82436d4ecdf3a6e9047): https://www.nirsoft.net/utils/tflash210.zip
3. Run the .exe with Wine **Staging**
4. Right click on the icon
5. Context menu should show
Regression test:
1. Run XChat
2. Right click
3. Context menu should show in the same place as without patch
Reviewers: davidedmundson, #plasma_workspaces
Reviewed By: davidedmundson, #plasma_workspaces
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22767
Summary: kcrash must be used else it will not be linked and crashes will crash instead of kcrashing
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23487
Summary:
Also drop checking if the suffix exists, the code is only reached
because this condition has been checked before
Seen while browsing code, no app known to me which would set a non-absolute
desktop file.
Reviewers: hein, broulik, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23417
Summary:
Shows a busy indicator in the TextField.
Depends D22723.
BUG: 409959
Test Plan: Searched things, eventually it disappears, I sometimes don't really know what's still doing, maybe we could add some more information at some point.
Reviewers: #plasma, #vdg, broulik
Reviewed By: #plasma, #vdg, broulik
Subscribers: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22514
Summary:
After the change to "Capacity degradation" was announced on
https://pointieststick.com/2019/08/24/kde-usability-productivity-week-85/, it turned out
that nobody could understand the new string either. :(
This patch changes it to something much clearer: suggested by a user: "Battery health".
This string has the advantage that it does not require knowing that batteries degrade,
and uses the same percentage scale as other operating systems.
Test Plan: {F7279584, size=full}
Reviewers: #vdg, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, aspotashev, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23448
Summary:
Because the fake {nav Switch User} item in the switcher UI counts as a session, the button
was always being shown. But if and when that changes and the fake item is no longer shown,
the {nav Switch User} button itself will stops being shown potentially locking out
non-logged-in users in multi-user computers where the only logged-in user has locked the
screen.
This patch drops the conditional check entirely and always shows the {nav Switch User}
button when session creation/switching is possible.
Test Plan: No change; {nav Switch User} button is still shown.
Reviewers: mart, #plasma, #vdg, filipf
Reviewed By: #vdg, filipf
Subscribers: filipf, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23279
Summary:
Same deal as D23306. We need to tell AppStream generators to exclude these files from
metadata indexing so Discover and other software center apps don't show duplicate
entries. This happens because kpackagetool5 automatically generates appstream metadata
already that marks Klipper as a Plasma addon, so the additional entries are not necessary.
Test Plan: None; can't test AppStream changes. :/
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23320
Summary:
Companion patch to D23270
The same logic explained in D23270 applies here: using the text "Capacity degradation"
is much clearer than "capacity" when referring to how much of the battery's original
capacity is remaining due to degradation.
Test Plan: {F7264994, size=full}
Reviewers: #vdg, broulik, #plasma, filipf
Reviewed By: #vdg, broulik, #plasma, filipf
Subscribers: aspotashev, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23271
Summary:
Retry after D23237
Vendor and Product will be shown in the energy information kcm after D23152
Test Plan:
After:
{F7260208}
Reviewers: #vdg, #plasma, broulik, ngraham
Reviewed By: #vdg, #plasma, broulik, ngraham
Subscribers: ngraham, alexde, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23260
Summary:
Only fetches the properties name and command.
Avoids bringing a libksysguard dependency into libtaskmanager.
I also checked that we don't have a space at the end of the command.
That appears to be a relic from an older time.
Test Plan:
Unit tests exist on KProcessList.
Task manager applications appear fine, I don't know any good edge cases
that go through this code to test.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23185
Summary:
Those information mostly clutter the plasmoid UI and are not very useful in the energy plasmoid
The battery plasmoid represents the state of the battery, for battery information we have the Energy information KCM in kinfocenter that will display this after D23152 .
Test Plan:
Before:
{F7257309}
After:
{F7257310}
Reviewers: ngraham, #plasma, broulik, #vdg, filipf
Reviewed By: ngraham, #vdg, filipf
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23237
l10n daemon script
Nate Graham
Marco Martin
David Edmundson
Konrad Materka
Kai Uwe Broulik
Laurent Montel
Jonathan Riddell
Friedrich W. H. Kossebau
Aleix Pol
Shawn Starr
Méven Car
David Faure