Summary:
Instead of guessing it will be the first argument, which leads to very
weird behavior.
Test Plan:
Checked the kcm still works
Played around with it
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8993
Summary:
Related to patch https://phabricator.kde.org/D7047 . Pointed out by @ngraham
Make a new option called "Edge filling". Users can choose either "Blur image" or "Solid color". They are only visible when the image filling mode is "Center" or "Scale and keep ratio".
When it is "Center":
{F5447565}
When it is "Tile":
{F5447053}
Reviewers: ngraham, jensreuterberg
Reviewed By: ngraham, jensreuterberg
Subscribers: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8441
Summary:
There's a bunch of code referring to this setting but not such a setting,
so the qml engine is confused and outputs tons of warnings
Reviewers: #plasma, guoyunhe, ngraham, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8807
Summary:
On wayland we're using Qt scaling.
This normally handles most scaling stuff itself, except because we're
explicitly forcing a source size, we need to scale that.
Test Plan:
Loaded a 4k wallpaper from internet
Looked at the tiny pixels
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8826
Summary: This is the implementation of the new Plasma Corona API, as described in https://phabricator.kde.org/D8566
Reviewers: #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: mwolff, apol, mart, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8567
Summary:
Composing CJK character requires a lot more key comparing to latin
characters. The raw length check does not make much sense for query string
in CJK characters. Here we use a simple algorithm to query the character
script property in unicode. If they are belong to CJK, use length 2 instead
of 1 for the character.
Test Plan:
Search "系" (normally requires three key press "x + i + 1" under pinyin) under
zh_CN in krunner and get some result instead of nothing.
Reviewers: hein, broulik
Reviewed By: hein
Subscribers: cfeck, ihipop, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8771
Summary:
This introduces the use of QQmlParserStatus to delay populating
the model until all properties have been set, to avoid delegate
churn.
TasksModel is also meant to be used by C++. There's no good way
to determine whether an object is being instanciated by QML
during construction time, therefore this patch also introduces a
delay in initial population of the model after construction via
a single-shot timer. At the time the slot is invoked we know if
we're used by QML (because QQmlParserStatus::classBegin has
either been called or not by then) so we can decide to populate
or wait more for QQmlParserStatus::componentComplete.
I'm not super happy with this behavior change for C++ users,
however as the model is usually used via QML currently, it's
pragmatic to optimize performance for the common case, and it
doesn't technically break QAbstractItemModel semantics, as model
population isn't required to be sync.
There's a decent change this fixes a recently-reported crash as a
by-product:
CCBUG:386630
Reviewers: #plasma, davidedmundson, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8723
Summary:
Right now, new Action always appends to the list, but application may
want to add new action in the middle of the menu. This breaks such
application with dynamic menu entries. This change tries to keep the
order of actions same as the order in dbus request.
Test Plan: Manually tested the brokened menu in certain applications.
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8585
Summary:
Changes the button in the wallpaper chooser marked "Open..." to say "Add Image..". This matches the text style for the button in slideshow mode, which says, "Add Folder"
Also added ellipses to "Add Folder"; it's now "Add Folder..."
Test Plan:
Tested in KDE Neon.
Before:
{F5473479}
After:
{F5473507}
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: aspotashev, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8658
Summary:
BUG: 345940
Move the "Enable Power Management" checkbox to the top of the window to match other applets (bluetooth, network)
Reviewers: #plasma_workspaces, broulik, mck182, davidedmundson, mart
Reviewed By: #plasma_workspaces, davidedmundson, mart
Subscribers: mart, jensreuterberg, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8607
remove invalid and superfluous markup <qt> + </qt> in kcfg file
add TranslationSystem=kde in kcfgc file to generate i18n() calls at build time for these tooltips
using the catalog klipper defined with setApplicationDomain
Differential Revision: https://phabricator.kde.org/D8453
Summary:
AFAICS the only other user for the engine (other than the applet I'm
porting) is the runner for KRunner, where links don't work anyway.
Port to QRegularExpression while at it.
Test Plan: Tested with the upcoming dict applet.
Reviewers: #plasma, davidedmundson, broulik, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8534
Summary:
This was tricky bug to track down, needed to add debug statements in
literally every functions.
The flow of events is something like this, At startup:
- We don't have information about actual brightness for few seconds
- In this period, brightness slider have default value of 1
- This triggers the function which sets batterymonitor.screenBrightness
- onScreenBrightnessChanged gets called, which sets the actual
brightness
- onScreenBrightnessChanged have a guard for disableBrightnessUpdate but
since we have it marked as false initially, we proceed to set actual
brightness to 1
- However before we set value of brightness to 1, we do get actual
brightness back from dataengine, and our call overrides it to 1 later.
- On desktop we do get 2nd dataChanged event from somewhere, so
brightness is proper, but on mobile that is not case and results in
brightness staying at 1.
To fix this bug, we set disableBrightnessUpdate true at startup, and
when there is actual brightness change from powerdevil or
powermanagement engine, Logic.js takes care of enabling and disabling
brightness change.
(I quite like the boolean trap there in variable name :P .. will fix in
another change in master)
Test Plan:
Tested on desktop and mobile, verified that
- Brightness keys work
- Brightness slider works
- Scroll to change brightness works
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8462
Summary:
Instead of returning "<dl>\n<dt><b></b></dt>\n<dd></dl>"
when the word doesn't exist, return a proper readable string so users
know that the lookup is done and nothing was found.
Test Plan: I'm porting the dict applet to QtQuick, review request coming soon.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8419
Aleix Pol
l10n daemon script
Kai Uwe Broulik
Friedrich W. H. Kossebau
Guo Yunhe
David Edmundson
Andras Mantia
Weng Xuetian
Eike Hein
Jonathan Riddell
Nathaniel Graham
David Faure
Burkhard Lück
Christoph Feck
Алексей Шилин
Bhushan Shah