Allow the Panel to get active keyboard focus via a kwyboard shortcut which will cycle between all panels.
When a panel has focus, the active focus can be navigated around either with tab/backtab or arrow keys.
Simple popup applets which only display an icon will work automatically,
Complex applets like the System tray or the taskbar will have focus that can navigate on all their sub-elements, to activate a particular systray applet or activate a particular window
Co-authored with Benjamin Port<benjamin.port@enioka.com>
CCBUG: 352476
The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.
Here was my full process for making this change:
1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+ " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
When using the lock/logout applet it feels strange, to get only at two
options a confirmation dialog. Additionally it feels odd to answer for
confirmation when neither the option triggered by Shortcuts nor the
Plasma menu asks for confirmation. Suspend and hibernate are the two
options where no data is lost, there is no need to ask for confirmation.
In the port from the data engine several operations were subtly renamed
to match the new library method calls. This left them out-of-sync with
the existing config keys.
With the UI changes in Kicker and the logout screen over the past years
the concept of "leave" with a default shutodwn action has gotten muddy.
Kicker shows all the options explicitly, the logout applet has got left
behind, and is currently a bit broken. The leave option currently always
shutdown regardless.
It's perfectly valid to want to have a short applet shortcut to log out
sometimes, and shutdown in other times.
This patch adds explicit options for logout and reboot, and clarified
the UI presentation of shutdown to match what it currently actually
does.
BUG: 424426
BUG: 402081
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
Summary:
This patch changes the logout screen labels to match the labels in the SDDM theme.
Reboot --> Restart
Logout --> Log Out (Title Capitalization)
It also adjusts the corresponding messages that use the verbs.
Reviewers: #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19458
Summary:
[copy-pasted from T10500:]
Problems with the current term:
- It's a somewhat severe-sounding technical term that doesn't intrinsically mean much to the average person. To the extent that it does, the connotations may be negative (e.g. when a misbehaving kid is being kept out of school)
- Our two major closed-source desktop competitors (macOS and Windows) both use the term "Sleep", so user familiarity with "Suspend" is low and falling all the time
I'd like to propose that we use "Sleep" instead, to address the above issues. It's a nicer
word in general, and since it's what our competitors use, we benefit from user familiarity.
We also recently adopted a moon icon with Zs for this, which visually connotes sleep. So it
would make sense to update the string too, because then the string and the icon will both
match.
Test Plan:
KRunner, searched for "Sleep": {F6640273}
KRunner, searched for "Suspend": {F6640284}
Kickoff, searched for "Sleep": {F6640309}
Kickoff, searched for "Suspend": {F6640315}
SDDM theme: {F6626026}
Logout screen: {F6626010}
Logout widget, UI: {F6626034}
Logout widget, config: {F6626035}
Reviewers: #vdg, #plasma, davidedmundson, filipf, mart
Reviewed By: #vdg, #plasma, filipf, mart
Subscribers: abetts, filipf, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10500
Differential Revision: https://phabricator.kde.org/D19185
Summary:
As there are only a few QML files in the respective /ui subdir, having the
JS file in the same dir still provides good overview
Test Plan: Applets UI & Config still work as before
Reviewers: #plasma, mart, broulik, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11145
Summary:
anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled
CCBUG:372721
Test Plan: opened all config dialogs both in ltr and ltr layouts
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3456
Summary:
anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled
CCBUG:372721
Test Plan: opened all config dialogs both in ltr and ltr layouts
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3456
Summary:
Leave action is checking on canLockScreen to enable the action instead of Lock action.
Fix the mistake so now Lock action is checking for canLockScreen and Leave action not anymore.
Test Plan: Lock action is now checking for canLockScreen and Leave action not anymore.
Reviewers: #plasma, sebas
Reviewed By: #plasma, sebas
Subscribers: plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2529
Summary:
Leave action is checking on canLockScreen to enable the action instead of Lock action.
Fix the mistake so now Lock action is checking for canLockScreen and Leave action not anymore.
Test Plan: Lock action is now checking for canLockScreen and Leave action not anymore.
Reviewers: #plasma, sebas
Reviewed By: #plasma, sebas
Subscribers: plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2529
- Remove unused imports
- Ensure the heading is readable (needs to use SystemPalette color not Plasma theme color)
- Use a more sensible heading
- Make sure at least one action remains enabled
Now when the applet is on the Desktop the dialog is positioned properly
but in a panel it's still broken. Looks like a bug in PlasmaComponents.Dialog
CCBUG: 349887
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Aleix Pol
Benjamin Port
Alexander Lohnau
Felipe Kinoshita
Nate Graham
David Edmundson
Sandro Knauß
Filip Fila
Laurent Montel
Krešimir Čohar
Friedrich W. H. Kossebau
Marco Martin
Olivier Felt
andreas kainz
Kai Uwe Broulik
Lukáš Tinkl