Summary:
BUG: 397537
Earlier plasmashell assumed that you'll get free space info immediately (which is not true in case of losing connection to server containing a mounted filesystem - statfs will wait for response forever and freeze everything since it's happening in main thread)
I moved obtaining that info into different thread so that case won't freeze anything anymore.
It creates exactly one thread per one path. If a path is already being processed, new thread won't be created.
Also I implemented a timer used to notify about broken connection after 15 seconds.
Reviewers: broulik, ngraham, davidedmundson
Reviewed By: broulik
Subscribers: ngraham, anthonyfieroni, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14895
Backported to 5.12 LTS (sans notification due to new strings) for impact to corporate setups
CCBUG: 399945
(cherry picked from commit e1c19ce4da)
It would only detect changes to existing device actions but not adding or removing them.
Moreover, the list of actions was never updated at runtime, only the list of predicates for the device.
This causes Device Notifier to pick up added, removed, or modified device actions only on startup.
Differential Revision: https://phabricator.kde.org/D15613
Summary:
BUG: 397537
Earlier plasmashell assumed that you'll get free space info immediately (which is not true in case of losing connection to server containing a mounted filesystem - statfs will wait for response forever and freeze everything since it's happening in main thread)
I moved obtaining that info into different thread so that case won't freeze anything anymore.
It creates exactly one thread per one path. If a path is already being processed, new thread won't be created.
Also I implemented a timer used to notify about broken connection after 15 seconds.
Reviewers: broulik, ngraham, davidedmundson
Reviewed By: broulik
Subscribers: ngraham, anthonyfieroni, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14895
All the information we need (player capabilities and playback status) is already present and managed by the PlayerContainer
BUG: 397685
FIXED-IN: 5.13.5
Differential Revision: https://phabricator.kde.org/D14970
On teardown with the popup expanded, the cleanup handler might fire with us already having been deleted.
BUG: 397105
FIXED-IN: 5.12.7
Differential Revision: https://phabricator.kde.org/D14651
We don't merge URLs and it probably doesn't make sense with the way grouping is currently implemented.
BUG: 396741
FIXED-IN: 5.12.7
Differential Revision: https://phabricator.kde.org/D14287
Summary:
Using the DBus API directly is done in both powerdevil and kscreen ATM.
Leaving the time dataengine the odd one out. It's also not used on Linux
where we use the more appropriate kernel signal, so linking a dead library is
extra pointless
Test Plan: Tested compile by altering some #ifdefs
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11966
Summary:
Add simple volume control to Media Controller applet. Volume can by changed by:
- mouse wheel on applet icon (3 % step), and
- new global shortcuts (5 % step, unbound by default).
There is no mute support currently (mpris interface does not have a mute method so we would have to keep
track of old volume).
BUG: 386588
Test Plan: Tested in daily use with Cantata and SMPlayer. There is no UI change.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, nicolasfella, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11021
Summary:
The urls of the BBC weather feeds seem to have changed, resulting in the
dataengine to use no longer existing urls.
I could not find the change documented somewhere and also do not know about
a contact person with BBC, so done based on examples on website, trial &
error.
There are some data issues visible in the new data feeds, so chance is the
feeds might see more rework and might break things again. But without any
contract or formal agreement we can just play catch-up.
BUG: 392510
Test Plan:
Existing configured weather applets using a location from a BBC weather
service work again.
Newly configured weather applets using a BBC weather service also work.
Reviewers: #plasma, jriddell, cfeck
Reviewed By: cfeck
Subscribers: cfeck, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11808