Summary:
Apparently wl-shell fullscreen is broken on Qt 5.12 now, but we don't need this
workaround anymore.
BUG: 399918
Test Plan:
Clicked on logout, got the greeter. Without this patch, the greeter
was not visible.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16381
Summary:
BUG: 397537
Earlier plasmashell assumed that you'll get free space info immediately (which is not true in case of losing connection to server containing a mounted filesystem - statfs will wait for response forever and freeze everything since it's happening in main thread)
I moved obtaining that info into different thread so that case won't freeze anything anymore.
It creates exactly one thread per one path. If a path is already being processed, new thread won't be created.
Also I implemented a timer used to notify about broken connection after 15 seconds.
Reviewers: broulik, ngraham, davidedmundson
Reviewed By: broulik
Subscribers: ngraham, anthonyfieroni, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14895
Backported to 5.12 LTS (sans notification due to new strings) for impact to corporate setups
CCBUG: 399945
(cherry picked from commit e1c19ce4da)
Summary:
In the lock screen, pressing the enter key while the UI is not yet
visible ends up trying to unlock (and would usually fail because the
password field is empty).
Ensure that the UI is visible before unlocking.
BUG: 395671
Test Plan:
Lock the session, press enter. The UI should appear without any
"Unlocking failed" message.
Reviewers: #plasma, #vdg, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: ngraham, davidedmundson, abetts, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16219
The setting was supposed to be disabled when global menu service was unavailable.
However, the service is now autostarted based on whether there is a global menu "view" available.
The property got removed but forgotten here.
Differential Revision: https://phabricator.kde.org/D16149
Summary:
The favicon_id is not used in the query results, and may not even exist
when the places db has been created with FF 58 or later. In case the
column does not exist the query fails completely.
BUG: 398305
Test Plan:
1. Create a new FF profile
2. Add some bookmarks
3. Do some queries
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15305
Summary:
When unmounting a removable device from dolphin, the device notifier
will popup saying the device can now be safely removed. But the popup
never auto-hides.
Test Plan:
Plug a USB pen drive
Unmount it from dolpin
Device notifier should popup and hide itself after 3 seconds
Reviewers: #plasma, #vdg, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16045
org.kde.slideshow is duplicated at compile time, so translations aren't extracted for it.
Setting an explicit domain fixes that.
Differential Revision: https://phabricator.kde.org/D16037
Summary:
KSmserver is currently very heavily tied to the shutdown prompt dialog.
On upgrades a user ends up in a situation where they have an old
ksmserver running but a newer shutdown dialog. This has caused issues
repeatedly in the past.
I want to make some changes to how the shutdown prompt is shown for
5.15. First step is making the old releases more robust.
Prompt looks ugly but a user will only see it at most once. Hopefully
never.
Test Plan:
rm'd the greeter
Got an ugly messagebox instead of nothing
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik
Subscribers: ngraham, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15869
Summary:
10 seconds isn't the best default value for slideshows. 15 minutes is more reasonable, and easier on battery life for laptops, too.
For comparison: macOS and Windows both default to 30 minutes.
Test Plan: {F6287038}
Reviewers: #plasma, broulik, mart, #vdg, abetts, davidedmundson
Reviewed By: #plasma, #vdg, abetts, davidedmundson
Subscribers: abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15785
In QtQuick Controls 2 (Plasma Components 3) there's separate signals for when the slider's value
changes "on its own" or by explicit user interaction. Pressing a keyboard shortcut changes the
value but doesn't cause the move signal to be emitted. Do this explicitly now.
It would only detect changes to existing device actions but not adding or removing them.
Moreover, the list of actions was never updated at runtime, only the list of predicates for the device.
This causes Device Notifier to pick up added, removed, or modified device actions only on startup.
Differential Revision: https://phabricator.kde.org/D15613
Summary:
Due to not passing `parent` to QAIM::index(), we were moving top-level
indices in the map instead. This meant the sort map would become out of
sync with the row move, and to the user it would look like both the
group children and unrelated top-level entries moved.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15550
Actions stop working when the original notification goes away, however the "Open..." notification when a job completed is added and
handled by us, so we can store it in the history and it will continue to function.
BUG: 398732
FIXED-IN: 5.14.0
Differential Revision: https://phabricator.kde.org/D15578
Summary:
Makes it work out of the box for both GTK 2 and GTK 3 applications.
Since both krdb and kde-gt-config overwrite their respective `gtkrc-2.0` we use a watcher to re-add our config key afterwards.
Test Plan:
Tested Pluma (Gtk3), now has global menu
Tested Gimp and Inkscape, now have global menu
When module isn't installed, prints a warning on console, shouldn't be too bad
Reviewers: #plasma, davidedmundson, fvogt, hein
Reviewed By: #plasma, hein
Subscribers: cgiboudeaux, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15315
Summary:
Makes it work out of the box for both GTK 2 and GTK 3 applications.
Since both krdb and kde-gt-config overwrite their respective `gtkrc-2.0` we use a watcher to re-add our config key afterwards.
Test Plan:
Tested Pluma (Gtk3), now has global menu
Tested Gimp and Inkscape, now have global menu
When module isn't installed, prints a warning on console, shouldn't be too bad
Reviewers: #plasma, davidedmundson, fvogt, hein
Reviewed By: #plasma, hein
Subscribers: cgiboudeaux, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15315
Summary:
Its rather pointless to spew an error message each time a query is done.
Output the warning message just once (on the default logging level), and
output further messages only at debug level.
Reviewers: #plasma, ngraham, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14806
Summary:
BUG: 397537
Earlier plasmashell assumed that you'll get free space info immediately (which is not true in case of losing connection to server containing a mounted filesystem - statfs will wait for response forever and freeze everything since it's happening in main thread)
I moved obtaining that info into different thread so that case won't freeze anything anymore.
It creates exactly one thread per one path. If a path is already being processed, new thread won't be created.
Also I implemented a timer used to notify about broken connection after 15 seconds.
Reviewers: broulik, ngraham, davidedmundson
Reviewed By: broulik
Subscribers: ngraham, anthonyfieroni, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14895
Jacopo De Simoi
David Edmundson
l10n daemon script
Fabian Vogt
Bhushan Shah
Kai Uwe Broulik
Oleg Solovyov
Thomas Surrel
Jonathan Riddell
Antonio Rojas
Stefan Brüns
Nathaniel Graham
Eike Hein