shell: pass hint by const reference

Function parameter 'hint' should be passed by const reference. (CWE-398)
4 years ago · 234d69b3d5
parent cd4c0f450b
commit 234d69b3d5
2 changed files with 2 additions and 2 deletions
--- a/shell/scripting/widget.cpp
+++ b/shell/scripting/widget.cpp
@ -177,7 +177,7 @@ QString Widget::userBackgroundHints() const
    return hintEnum.valueToKey(applet()->userBackgroundHints());
 }

-void Widget::setUserBackgroundHints(QString hint)
+void Widget::setUserBackgroundHints(const QString &hint)
 {
    QMetaEnum hintEnum = QMetaEnum::fromType<Plasma::Types::BackgroundHints>();
    bool ok;
--- a/shell/scripting/widget.h
+++ b/shell/scripting/widget.h
@ -53,7 +53,7 @@ public:
    QString globalShorcut() const;

    QString userBackgroundHints() const;
-    void setUserBackgroundHints(QString hint);
+    void setUserBackgroundHints(const QString &hint);

    Plasma::Applet *applet() const override;