[Notifications] Fixup setSourceModel

Don't bother if the model is the same

Differential Revision: https://phabricator.kde.org/D27037
wilder-5.18
Kai Uwe Broulik 6 years ago
parent 31303ad354
commit 1c0c8ddef4
  1. 8
      libnotificationmanager/limitedrowcountproxymodel.cpp
  2. 8
      libnotificationmanager/notificationgroupcollapsingproxymodel.cpp

@ -34,8 +34,12 @@ LimitedRowCountProxyModel::~LimitedRowCountProxyModel() = default;
void LimitedRowCountProxyModel::setSourceModel(QAbstractItemModel *sourceModel) void LimitedRowCountProxyModel::setSourceModel(QAbstractItemModel *sourceModel)
{ {
if (this->sourceModel()) { if (sourceModel == QAbstractProxyModel::sourceModel()) {
disconnect(this->sourceModel(), nullptr, this, nullptr); return;
}
if (QAbstractProxyModel::sourceModel()) {
disconnect(QAbstractProxyModel::sourceModel(), nullptr, this, nullptr);
} }
QSortFilterProxyModel::setSourceModel(sourceModel); QSortFilterProxyModel::setSourceModel(sourceModel);

@ -36,8 +36,12 @@ NotificationGroupCollapsingProxyModel::~NotificationGroupCollapsingProxyModel()
void NotificationGroupCollapsingProxyModel::setSourceModel(QAbstractItemModel *source) void NotificationGroupCollapsingProxyModel::setSourceModel(QAbstractItemModel *source)
{ {
if (sourceModel()) { if (source == QAbstractProxyModel::sourceModel()) {
disconnect(sourceModel(), nullptr, this, nullptr); return;
}
if (QAbstractProxyModel::sourceModel()) {
disconnect(QAbstractProxyModel::sourceModel(), nullptr, this, nullptr);
} }
QSortFilterProxyModel::setSourceModel(source); QSortFilterProxyModel::setSourceModel(source);

Loading…
Cancel
Save