Summary:
- swap out manual management for a PrintDHelper class that allocates
an action and MessageBoxHelper, runs the script, and checks the
result.
- use _data() to run the helper with different data; this improves
observability as well.
Test Plan: - Run tests, see same results as before
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D23164
Summary:
With formatting there is an internal value, which represents
the true value of a field additionaly to the normal,
visible, text.
For fields which have formatting rules these might differ
and for calculations the internal value is used. The behavior
to format on focus in / focus out events is similar to
that of Acrobat reader.
Test Plan: Needs unit test
Reviewers: aacid
Subscribers: okular-devel
Tags: #okular
Maniphest Tasks: T8886
Differential Revision: https://phabricator.kde.org/D13171
Summary:
- Correct QQC2 import
- Apply search field changes from Thumbnails here as well
Test Plan:
- Open https://openboard.ch/download/Tutoriel_OpenBoard_1.5EN.pdf with okularkirigami
- open the context drawer
- switch to the "Table of Contents" tab
- the ToC should load successfully
Reviewers: #okular, bshah
Reviewed By: bshah
Subscribers: bshah, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D23066
Summary:
Now //fontBoundaries// always has smaller width than //boundingRect// from
```
void QPainter::drawText(const QRect &rectangle, int flags, const QString &text, QRect *boundingRect = nullptr)
```
which is required to enclose the whole text. The difference is only several pixels, but sometimes it can cause visual problems. You can see the sidebar without and with this patch in Russian language with Noto Sans 10pt font on a picture below.
{F7177644}
Now the first and the last symbols are fully visible.
Reviewers: #okular
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D23012
Summary: Adds tootip, different icons depending on checked state and fixed functionality
Test Plan:
- Open a document
- click bookmark action
- the bookmarked page should appear in the bookmarks tab of the contextDrawer
Reviewers: #okular, #plasma:_mobile, ngraham
Reviewed By: ngraham
Subscribers: ngraham, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D22904
The previous code used two consecutive calls to the method
slotChangeDrawingToolEngine to reset the m_drawingEngine
member (i.e., to delete it and to create a new one from scratch).
That worked; however, as a side effect the calls to
slotChangeDrawingToolEngine also set the cursor to an arrow,
which happens every time one continuous stroke is finished.
This went unnoticed because when drawing in presentation mode
the cursor is an arrow anyway. However, in anticipation
of future patches that change the cursor to a cross-hair
when drawing, this explicit setting of the arrow shape
needs to go. Therefore this patch replaces the two calls
to slotChangeDrawingToolEngine by the code they contain,
minus the code to set the cursor shape. The new code is
only one line longer, and more readable too.
João Netto
Peter Eszlari
l10n daemon script
Adriaan de Groot
Albert Astals Cid
Andre Heinecke
Jonah Brüchert
Natsumi Higa
Yuri Chornoivan
Jan Grulich
Andrey Yashkin
Oliver Sander
Christoph Feck