Since unfortunately some of the autogenerated includes don't pass the
checks we do a trick of building out of source and then specifying the
.*/okular/.* path as the only includes we care about
autotests/*, conf/* , mobile/* , shell/*, part.cpp, extension.cpp
The code compiles and all unit tests pass (except for the two that
fail on master too).
Summary:
- Correct QQC2 import
- Apply search field changes from Thumbnails here as well
Test Plan:
- Open https://openboard.ch/download/Tutoriel_OpenBoard_1.5EN.pdf with okularkirigami
- open the context drawer
- switch to the "Table of Contents" tab
- the ToC should load successfully
Reviewers: #okular, bshah
Reviewed By: bshah
Subscribers: bshah, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D23066
Summary: Adds tootip, different icons depending on checked state and fixed functionality
Test Plan:
- Open a document
- click bookmark action
- the bookmarked page should appear in the bookmarks tab of the contextDrawer
Reviewers: #okular, #plasma:_mobile, ngraham
Reviewed By: ngraham
Subscribers: ngraham, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D22904
otherwise it doesn't get shown on Plasma Mobile as well, most
distribution doesn't enable mobile app or splits it in seperate package
so this should not be problem
Summary: Remove all QtQuick Controls 1 imports and replace by QtQuick Controls 2
Test Plan: The mobile app behaves just as before
Reviewers: #okular, ngraham
Reviewed By: ngraham
Subscribers: ngraham, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D21675
Summary: Move the error label to the results grid view, which fixes the layout of the TextField.
Test Plan: TextField and label are still visible if no search result is found.
Reviewers: #okular, ngraham
Reviewed By: ngraham
Subscribers: ngraham, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D21551
Summary: Port the drawer to QQC2
Test Plan: It still has the same features as before
Reviewers: #okular, ngraham
Reviewed By: ngraham
Subscribers: ngraham, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D21550
Summary:
This only depended on okularpart due to the export header used in the
kcfgc file, so use a dedicated one for the mobile components that doesn't
export anything.
This enables disabling the part build for mobile-only builds such as
Android, and thus removing the need for some difficult dependencies
like KParts.
Reviewers: aacid
Reviewed By: aacid
Subscribers: aacid, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D19037
Summary:
There's two issues here:
- Activity::onCreate triggered before the C++ side was loaded, so the
call to C++ failed (causing a crash). So delay that until we are ready.
- The static instance of URIHandler in the header caused it to duplicate
into each translation unit, causing main.cpp to not see what android.cpp
wrote into it.
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D18399
Christoph Feck
Albert Astals Cid
Laurent Montel
Aleix Pol
Ahmad Samir
l10n daemon script
Yuri Chornoivan
Jonah Brüchert
Nicolas Fella
Bhushan Shah
Volker Krause