The info message bubble that shows up in the okular window in testeRectSelectionStartingOnLinks()
interfereswith the mosue selection making the test fail on HiDPI monitors
with resolution 3840x2160; hiding the info message lets the unit test pass.
It's a lot nicer than manually painting a KPixmapSequence and supports high dpi out of the box.
The new code requires Frameworks >= 5.61, it is therefore only enabled
if at least that Frameworks version is available.
By waiting for the delayResizeEventTimer to trigger before starting the
test.
The test "randomly" failed before, which shows there's an actual bug in
the code, but the actual bug is "if you are moving the mouse over a
field that has a on focus action and at that very same time the
delayResizeEventTimer triggers, the action won't be executed".
That's almost impossible to reproduce in real life so i'm going to
pretend the bug is not there for all purposes
Some discussions at https://phabricator.kde.org/D25484.
This MR adds:
* mouse middle button event handler for closing a tab
* an `undo close tab` action
Test plan:
1. Compile and install.
2. Enable `Open new files in tabs`.
3. Open two documents. They should be opened in two tabs in the same window.
4. Middle click one of the tabs. It should be closed.
5. Choose `File`-`Undo close tab`. The closed tab should be reopened.
6. Middle click one of the tabs. It should be closed.
7. Press <kbd>Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>T</kbd>. The closed tab should be reopened.
Remove indentation that breaks formatting when compiling with namespaced stylesheets.
BUG: 415468
Differential Revision: https://phabricator.kde.org/D26190
(cherry picked from commit 9ac31982c5)
Remove indentation that breaks formatting when compiling with namespaced stylesheets.
BUG: 415468
Differential Revision: https://phabricator.kde.org/D26190
Use jq to filter compile_commands.json to not include the compilation of
autogenerated files, we don't want to check those
Also filter out the synctex folder, since that is imported code
Since unfortunately some of the autogenerated includes don't pass the
checks we do a trick of building out of source and then specifying the
.*/okular/.* path as the only includes we care about
autotests/*, conf/* , mobile/* , shell/*, part.cpp, extension.cpp
The code compiles and all unit tests pass (except for the two that
fail on master too).
The code compiles and okular seems to load and work as before, all unit
tests pass except (parttest and epubgeneratortest, but they fail on master
too).
Ahmad Samir
Laurent Montel
Kai Uwe Broulik
Albert Astals Cid
kezi olio
l10n daemon script
Yuri Chornoivan
Bob Bai
Christoph Feck
Antonio Rojas
Aleix Pol
Jonathan Riddell