After removing kdelibs4support, these flags are enabled:
-DQT_USE_FAST_OPERATOR_PLUS -DQT_NO_CAST_TO_ASCII
-DQT_NO_CAST_FROM_ASCII -DQT_NO_URL_CAST_FROM_STRING
-DQT_NO_CAST_FROM_BYTEARRAY
So wrap naked string and character literals in QStringLiteral,
QLatin1Char and QLatin1String as appropriate.
To more easily see the changes, use «git show --color-words».
Thank $DEITY for vim macros.
Gives following error otherwise,
/usr/include/qmobipocket/qmobipocket_export.h:22:23: fatal error: kdemacros.h: No such file or directory
compilation terminated.
size the page correctly to not have the horizontal
scrollbar when not needed, and make sure the flickable
is not interactive, as flicking is managed by hand
with a mousearea
The situation described here occurs in particular when first increasing
the size of the component considerably, and then reducing it again
(such as switching to and from full screen in some application)
Error discovered in Peruse, but will happen elsewhere as well.
Don't go through QUrl -> QString -> QUrl when opening files from the
argument list.
Don't be strict when opening URLs that come from the dbus interface.
REVIEW: 127042
At least in PDF which is the only backend with form support
Radio buttons are a bit of a mess since they're supposedly also uncheckable if NoToggleToOff is not set but in Adobe Reader they never are
BUGS: 357743
Okular was checking for Q_WS_X11 definition (which is not available since Qt 5) to detect CUPS, so detection always fails making CUPS parameters ignored.
REVIEW: 127036
Drops the x11 fallback. We were falling back to QX11Extras that were in
fact using QScreen internally.
Also remove the QDesktopWidget fallbacks for the same reason.
Drops some API for fetching the dpi and unifies it with ::realDpi(QWidget).
Based on Sebas's patch.
Reviewed by Albert.
REVIEW: 126913
Try fixing mainshelltest: one more passes now
QUrl is not automatically exposed to DBus so the DBus call would fail.
Changed the parameter to QString instead so that DBus invocation works.
mainshelltest: set QStandardPaths to test mode
Parse command line flags with a single dash as a long option
Unlike KCmdLineArgs QCommandLineParser treats options starting with a
single minus as multiple short options by default.
Previously okular -unique would fail with the following error:
Unknown options: u, n, i, q, u, e.
Also changed mainshelltest to use two dashes in case this behaviour
should change in the future.
mainshelltest failures have been reduced from 15 to 4 by this commit.
Fix docdata saving and added a warning message if it fails
If the ~/.local/okular/docdata directory didn't exist previously
creating the docdata file would fail as there are missing paths.
It seems that KStandardDirs used to create the okular/docdata directory
automatically, with QStandardPaths we have to create it manually.
mainshelltest is down to one failed test now
Fix final test case in mainshelltest
as we call QProcess::terminate the exit code will not be 0
REVIEW: 126192
This removes kdelibs4support for all generators except the mobipocket one.
The test executable for kimgio needs some windows fixes too, so I'll try
to make a separate review for that.
REVIEW: 126375
Martin T. H. Sandsmark
Bhushan Shah
Aleix Pol
Albert Astals Cid
Marco Martin
Dan Leinir Turthra Jensen
Thomas Friedrichsmeier
David Rosca
Armin K
Albert Vaca
Krzysztof Pyrkosz
Alex Richardson
Patrick Spendrin