Parker messed up the logic that force it to be in text selection mode
to be on non text selecion mode when doing an unrelated change.
As the "bug" as showed we can selectAll in non text selection mode as well
so remove the check altogether
BUGS: 159276, 319554
FIXED-IN: 4.10.4
So that the hoverIcon is not shown above the newly created annotation.
This was especially visible if the creation of the annotation triggers a
message box warning, because one could see both the annotation and the
hover icon as long as the warning wasn't closed.
Note that if a low-res 16x16 version is available, it is shown instead
of the 64x64 version actually used by PagePainter.
e.g. try with the default stamp "Okular"
- Changed property dialog title from "Highlight" to "Text Markup",
because it's used for Underline, Squiggle and Strike out too.
- Renamed Squiggly (adjective) to Squiggle (noun)
- Show the precise type of HighlightAnnotation in the review panel and
on right-click on a HighlightAnnotation
Removed name attribute from default tools (ie those from tools.xml), so
that they now get default names, which automatically translated if the
application language is switched.
With this patch, tools.xml no longer contains strings to be translated.
NOTE: Messages.sh was not tested
Two purposes:
- Have tooltips available even for user-created annotations (not just
the predefined ones)
- Avoid i18n strings in settings (NOTE: the "name" attribute will be
removed in next patch)
Some tooltips were created over new (eg for new tools), some were
rewritten to actually give instructions instead of repeating the name of
the tool, some were rewritten to avoid references to colors (because
colors are no longer fixed)
Just use the pointer as id :-)
This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future
Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
Make sure there's no ambiguity that the page number refers to
the preceding thumbnail. This is a bigger deal because the fix
in b0f64d2 took away a visual divider.
This seems to be what the original code wanted to achieve, but failed
due to a convoluted approach of setting the color of the current back-
ground role to a default palette's Base color ... instead we just leave
the palette untouched and set the correct background role now. Visual
noise be gone, yay.
CCMAIL:wstephenson@kde.org
Certain KDE color schemes have Window Background and View Text
not contrasting, which causes invisible icon labels when using
QPalette::Text on QPalette::Base. An example is the default
color scheme in openSUSE 12.3.
Thanks to Will Stephenson for noticing.
CCMAIL:wstephenson@kde.org
It turns out that the Places sidebar in Dolphin suffers from
the same bug, so a similar change should be done there. Frank?
CCMAIL:frank78ac@googlemail.com
Now that the pdf generator does not incorrectly delete the pixmaps
on a config change we need to repaint the viewports in case
there has been a inverted color change or something similar
This patch also removes the slot qualification to AnnotationWidget::applyChanges()
that I had added in "Show the same widget as the annotation properties dialog when
creating annotation tools", because it's not needed any more.
Since the size of pixmap is determined by the value of size variable,
we can directly read that variable instead of querying the pixmap.
Also note that "pixmap" comes from "hoverIcon", not from "icon", and
that piece of code wants to know the size of the latter. In case of
stamp annotations, however, they happen to be the same.
Note that previously the width attrubute was ignored by the PolyLine
engine and it always set width=1, that's why I had to change the default
value in tools.xml.
Jon Mease
Fabio D'Urso
Albert Astals Cid
Jaydeep Solanki
Peter Grasch
Eike Hein
Thomas Fischer