Because a cached dialog stays parented to the initial part, which might
not be the one used to open it.
This is especially visible now that we support more than one window per
okular process.
For example:
- User initially opens a dialog from window A
-> This dialog gets cached as child of A's PageView. This implies that
clicking on the dialog also brings window A to foreground.
- User re-opens the dialog from a different window B
-> The dialog is still a child of A's PageView, therefore clicking on the
dialog's frame brings A to the foreground, and B to the background.
Instead of listening on KConfigDialog's signals, this patch makes parts
listen on Okular::Settings::self()'s configChanged() signal.
Unlike KConfigDialogs, Okular::Settings::self() is unique and never
changes during the process lifetime, and therefore:
- A part can connect during initialization and receive notifications,
without depeding on KConfigDialog objects (which might be instanced
or deleted by a different part).
- The connection now survives deletion of the KConfigDialog.
Parker messed up the logic that force it to be in text selection mode
to be on non text selecion mode when doing an unrelated change.
As the "bug" as showed we can selectAll in non text selection mode as well
so remove the check altogether
BUGS: 159276, 319554
FIXED-IN: 4.10.4
So that the hoverIcon is not shown above the newly created annotation.
This was especially visible if the creation of the annotation triggers a
message box warning, because one could see both the annotation and the
hover icon as long as the warning wasn't closed.
Note that if a low-res 16x16 version is available, it is shown instead
of the 64x64 version actually used by PagePainter.
e.g. try with the default stamp "Okular"
I had added this special case because Poppler < 0.20 stored garbage
in the DOM node corresponding to inplaceText (but good data in contents).
This code copied the good value into inplaceText, so that our UI code,
which used to show the user what it read from inplaceText, showed the
good value instead.
Now that Okular only has contents, this special handling is no longer
needed.
It is still not perfect because for some reason poppler is painting outside the boundaries box (or we are not creating/setting it correctly)
but at least now it's not ultra hard to click in a note application at high zoom
FIXED-IN: 4.10.4
BUGS: 319637
Jon Mease
Yuri Chornoivan
l10n daemon script
Fabio D'Urso
Albert Astals Cid
Burkhard Lück
Azat Khuzhin