A lot of this code has been commented out for over
a decade and adds no value to the project.
It is only annoying when you look over it ;).
Same for the KNS2 support which was commented out.
Also some of the debug statements didn't even build
anymore, because the properties got removed/refactored.
find . \( -name "*.cpp" -or -name "*.h" -or -name "*.c" -or -name "*.cc" \) -exec clang-format -i {} \;
If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
Use jq to filter compile_commands.json to not include the compilation of
autogenerated files, we don't want to check those
Also filter out the synctex folder, since that is imported code
After removing kdelibs4support, these flags are enabled:
-DQT_USE_FAST_OPERATOR_PLUS -DQT_NO_CAST_TO_ASCII
-DQT_NO_CAST_FROM_ASCII -DQT_NO_URL_CAST_FROM_STRING
-DQT_NO_CAST_FROM_BYTEARRAY
So wrap naked string and character literals in QStringLiteral,
QLatin1Char and QLatin1String as appropriate.
To more easily see the changes, use «git show --color-words».
Thank $DEITY for vim macros.
- Initialize the kpsewhich QProcess in the fontLocate() method
- Remove the usage of fontProgressDialog and use the warning
signal to notify the user on the status of font generation.
- The change makes it "easier", in future, to kill the font
generation when the user opens a new document. Right now it
is not possible to stop the generation.
Reviewed by: Albert Astal Cid, Fabio d'Urso
(and thanks for the hints!)
CCMAIL: luigi.toscano@tiscali.it
He says:
"Thanks for the infrastructure work to John Layt and apologies for my (non-existent) reply to your mail..."
CCMAIL: john@layt.net
svn path=/trunk/KDE/kdegraphics/okular/; revision=754729
*** Note this is not a complete port, most of the generators use the
printFiles method which Qt 4.3 does not support, these have simply
been commented out until we find a solution. At least it removes
the dependency so we can remove from kdelibs.
svn path=/trunk/KDE/kdegraphics/okular/; revision=725660