Summary:
BUG: 382139
Previously these labels were white-on-light-blue with light themes; now they use the correct theme color property, and become black appropriately.
Test Plan:
Tested on KDE Neon (dev unstable). Verified that with the default Breeze color scheme, tab text is more readable when hovered over and then active but not in focus. See before and after:
{F3909142}
{F3909143}
Also tested these changes with all standard color schemes as well as the Oxygen theme to make sure that there were no visual regressions.
Reviewers: aacid, #okular, #kde_applications, broulik, sander, rkflx
Reviewed By: aacid, #okular, #kde_applications, rkflx
Subscribers: rkflx
Tags: #okular
Differential Revision: https://phabricator.kde.org/D7793
For reference, not even Konqueror uses the toolBarFont() for its
sidebar.
In fact, this seems to be the only usage of toolBarFont() I could find
in any KDE application.
Certain KDE color schemes have Window Background and View Text
not contrasting, which causes invisible icon labels when using
QPalette::Text on QPalette::Base. An example is the default
color scheme in openSUSE 12.3.
Thanks to Will Stephenson for noticing.
CCMAIL:wstephenson@kde.org
It turns out that the Places sidebar in Dolphin suffers from
the same bug, so a similar change should be done there. Frank?
CCMAIL:frank78ac@googlemail.com
Should never happen, but as it is the "main" widget of the part it might end up there if someone just says part->mainwidget->setfocus or something like that
At least this way the focus does not go down the drain and ends up in the sidebar list, which is not optimal but is better than getting the keyboard focus lost
forwardport r1185628 okular/branches/KDE/4.5/kdegraphics/okular/ui/sidebar.cpp: no need to look for a new current item if the sidebar is not even shown
svn path=/trunk/KDE/kdegraphics/okular/; revision=1185629
Make sure that setting the toc to be the current index does not break sidebar
visibility
Make Sidebar::isSidebarVisible symmetric with Sidebar::setSidebarVisibility
If showing the container make sure the list is also shown
svn path=/trunk/KDE/kdegraphics/okular/; revision=1152385
to allow changing sidebar pages by keeping the left mouse
button pressed and moving the cursor over the icon list,
similar to a popup menu or the treelist version of the
tab bar in Konversation.
A remaining bug in the sidebar is that switching iconlist
items using the keyboard arrow keys won't switch sidebar
pages. I will fix that next time, unless someone else is
faster.
svn path=/trunk/KDE/kdegraphics/okular/; revision=1034540
Anyway, this is what happens:
* I replaced the zoom combobox in the toolbar with the fit to width/page buttons. For one they look much cleaner and
also most users would never use the freezooming anyway.
* Removed the frame from the sidebar, making for a cleaner overall look. After all, nothing else has a frame.
* Let the statusbar stretch over the full width of the window. This again makes the app look cleaner.
* Used the same trick as in Gwenview: let the background shine through -> clean++
* Use QToolButton instead of QPushButton for the minibar buttons to fit the other buttons in all apps.
svn path=/trunk/KDE/kdegraphics/okular/; revision=887160
also, manually do the "highlight on hover" effect only for non-kstyle-based styles, as kstyle provide that effect on its own
svn path=/trunk/KDE/kdegraphics/okular/; revision=815952
Nathaniel Graham
Kevin Funk
Albert Vaca
Aleix Pol
Martin T. H. Sandsmark
Albert Astals Cid
Montel Laurent
Saheb Preet Singh
Vishesh Handa
Frederik Gladhorn
Jonathan Doman
Eike Hein
Elvis Stansvik
Albert Astals Cid
Pino Toscano
Sebastian Trueg
Malcolm Hunter