add info about alternative method to delete an annotation
add info about resize feature for annotations (text modified from commit log)
replace outdated rating.png with new bookmarks.png
add info about available bookmark actions in the table of Contents
Differential Revision: https://phabricator.kde.org/D8677
We don't need to delete the threadweaver job, threadweaver does it by itself,
and if we call deleteLater it may happen that the main thread deletes it
and then when the threadweaver thread tries to call the delete things are
gone and it goes kaboom
BUGS: 382725
Summary:
so that pixmap generation gets a chance to start before the text generation
This makes that on files where both the text generation and the pixmap generation
are slow at least we see something "as fast as possible" since only either text generation
or pixmap generation threads run at the same time
Reviewers: #okular, mlaurent
Reviewed By: mlaurent
Subscribers: michaelweghorn, dvratil, mlaurent, #okular
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8378
Summary:
FEATURE: 355283
The principle is simple. This patch enables overriding the default columns for Overview mode, if the document is small. For example, if document has 1 or 2 pages and the default columns in Okular settings is 3, Overview mode will enable 1 or 2 columns for better UX
Reviewers: #okular, rkflx, ngraham
Reviewed By: rkflx, ngraham
Subscribers: ltoscano, aacid, rkflx, ngraham
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8385
Summary: This is implemented using the Purpose framework.
BUG: 173896
Reviewers: aacid
Subscribers: #okular
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8244
Summary:
This patch enables HiDPI throughout the application
Every pixmap is multiplied by the devicePixelRatioF
QPainter code is ajusted to take the DPR value into account
All pixmaps get cached with the highest DPR of all screens. When moving the application to another screen, the cache doesn't have to be invalidated.
BUGS: 362856 383589
REVIEW: D6268
Allow user to click on url while on any selection mode
Based on https://git.reviewboard.kde.org/r/124961/ by Jake Linder <JakeLinder@mail.com>
Includes several autotests to try to minimize possible regressions as much as possible
BUGS: 318078
REVIEW: 130246
Summary:
BUG: 182994
Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.
Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
{F4257766}
Other less important information:
https://git.reviewboard.kde.org/r/130219/https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
Reviewed By: ngraham
Subscribers: aacid, ltoscano, ngraham
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8051
Summary:
BUG: 182994
Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.
Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
{F4257766}
Other less important information:
https://git.reviewboard.kde.org/r/130219/https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
Reviewed By: ngraham
Subscribers: aacid, ltoscano, ngraham
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8051
Show non-intrusive info messages whenever the search start over from the
beginning or the bottom of the document, instead of asking the user if
s/he wants to continue the search. This is consistent with search in
KWrite/Kate and with web browsers.
Based on work of and reviewed by Elvis Angelaccio
Summary:
The KPixmapSequence constructor needs the full path of the icon, so the
current code doesn't work and generates a "Invalid pixmap specified"
warning at runtime. By using KIconLoader we can fix this issue.
Test Plan: Search something and reach the end of document to make the animation start.
Subscribers: #okular
Tags: #okular
Differential Revision: https://phabricator.kde.org/D7996
Summary:
BUG: 382139
Previously these labels were white-on-light-blue with light themes; now they use the correct theme color property, and become black appropriately.
Test Plan:
Tested on KDE Neon (dev unstable). Verified that with the default Breeze color scheme, tab text is more readable when hovered over and then active but not in focus. See before and after:
{F3909142}
{F3909143}
Also tested these changes with all standard color schemes as well as the Oxygen theme to make sure that there were no visual regressions.
Reviewers: aacid, #okular, #kde_applications, broulik, sander, rkflx
Reviewed By: aacid, #okular, #kde_applications, rkflx
Subscribers: rkflx
Tags: #okular
Differential Revision: https://phabricator.kde.org/D7793
Summary:
The checkbox is checked and says "Warn me on closing more than one tab",
for that reason we can't use the default KMessageBox::questionYesNo since
there the checkbox is always not checked and it's when checked that you enable it
Inspired by code from torham zed torhamzed@yahoo.com at review request 126406
Reviewers: #okular, #kde_applications
Subscribers: alexeymin, ngraham, colomar, rkflx, #okular
Tags: #okular
Differential Revision: https://phabricator.kde.org/D7714
Summary:
The massive changes to the synctex code in D7594 pulled in a new library
(on windows only), reflect that in the linker flags.
Test Plan:
`craft okular` on Okular's master branch builds successfully with MSVC
2017 and Qt 5.9, build on Linux still fine.
Reviewers: #okular, aacid
Reviewed By: #okular, aacid
Tags: #okular
Differential Revision: https://phabricator.kde.org/D7809
Burkhard Lück
Henrik Fehlauer
Albert Astals Cid
Albert Astals Cid
Alexey Demennikov
Jonathan Riddell
l10n daemon script
Kevin Ottens
Lukas Hetzenecker
Renato Araujo Oliveira Filho
Christoph Feck
Yuri Chornoivan
Albert Freeman
Luigi Toscano
Nathaniel Graham
Elvis Angelaccio
Milian Wolff