using Part as class name makes it very easy to collide with other Parts out there and very ugly things will happen, add a namespace

svn path=/trunk/KDE/kdegraphics/okular/; revision=1040789
remotes/origin/KDE/4.4
Albert Astals Cid 17 years ago
parent f074fc2e15
commit 45c8faee16
  1. 4
      extensions.cpp
  2. 6
      extensions.h
  3. 16
      part.cpp
  4. 5
      part.h

@ -13,6 +13,9 @@
// local includes // local includes
#include "part.h" #include "part.h"
namespace Okular
{
/* /*
* BrowserExtension class * BrowserExtension class
*/ */
@ -114,6 +117,7 @@ void OkularLiveConnectExtension::postMessage( const QStringList &args )
"{ this.messageHandler.onMessage(" + arrayarg + ") }" ); "{ this.messageHandler.onMessage(" + arrayarg + ") }" );
} }
}
#include "extensions.moc" #include "extensions.moc"

@ -13,6 +13,9 @@
#include <kparts/browserextension.h> #include <kparts/browserextension.h>
namespace Okular
{
class Part; class Part;
class BrowserExtension : public KParts::BrowserExtension class BrowserExtension : public KParts::BrowserExtension
@ -51,6 +54,9 @@ class OkularLiveConnectExtension : public KParts::LiveConnectExtension
bool m_inEval; bool m_inEval;
QString m_evalRes; QString m_evalRes;
}; };
}
#endif #endif
/* kate: replace-tabs on; indent-width 4; */ /* kate: replace-tabs on; indent-width 4; */

@ -143,7 +143,7 @@ class FileKeeper
std::FILE * m_handle; std::FILE * m_handle;
}; };
K_PLUGIN_FACTORY( okularPartFactory, registerPlugin< Part >(); ) K_PLUGIN_FACTORY( okularPartFactory, registerPlugin< Okular::Part >(); )
K_EXPORT_PLUGIN( okularPartFactory( okularAboutData( "okular", I18N_NOOP( "Okular" ) ) ) ) K_EXPORT_PLUGIN( okularPartFactory( okularAboutData( "okular", I18N_NOOP( "Okular" ) ) ) )
static QAction* actionForExportFormat( const Okular::ExportFormat& format, QObject *parent = 0 ) static QAction* actionForExportFormat( const Okular::ExportFormat& format, QObject *parent = 0 )
@ -183,29 +183,29 @@ static QString compressedMimeFor( const QString& mime_to_check )
return QString(); return QString();
} }
static Part::EmbedMode detectEmbedMode( QWidget *parentWidget, QObject *parent, const QVariantList &args ) static Okular::Part::EmbedMode detectEmbedMode( QWidget *parentWidget, QObject *parent, const QVariantList &args )
{ {
Q_UNUSED( parentWidget ); Q_UNUSED( parentWidget );
if ( parent if ( parent
&& ( parent->objectName() == QLatin1String( "okular::Shell" ) && ( parent->objectName() == QLatin1String( "okular::Shell" )
|| parent->objectName() == QLatin1String( "okular/okular__Shell" ) ) ) || parent->objectName() == QLatin1String( "okular/okular__Shell" ) ) )
return Part::NativeShellMode; return Okular::Part::NativeShellMode;
if ( parent if ( parent
&& ( QByteArray( "KHTMLPart" ) == parent->metaObject()->className() ) ) && ( QByteArray( "KHTMLPart" ) == parent->metaObject()->className() ) )
return Part::KHTMLPartMode; return Okular::Part::KHTMLPartMode;
Q_FOREACH ( const QVariant &arg, args ) Q_FOREACH ( const QVariant &arg, args )
{ {
if ( arg.type() == QVariant::String ) if ( arg.type() == QVariant::String )
{ {
if ( arg.toString() == QLatin1String( "Print/Preview" ) ) if ( arg.toString() == QLatin1String( "Print/Preview" ) )
return Part::PrintPreviewMode; return Okular::Part::PrintPreviewMode;
} }
} }
return Part::UnknownEmbedMode; return Okular::Part::UnknownEmbedMode;
} }
#undef OKULAR_KEEP_FILE_OPEN #undef OKULAR_KEEP_FILE_OPEN
@ -218,6 +218,9 @@ static bool keepFileOpen()
} }
#endif #endif
namespace Okular
{
Part::Part(QWidget *parentWidget, Part::Part(QWidget *parentWidget,
QObject *parent, QObject *parent,
const QVariantList &args ) const QVariantList &args )
@ -2167,6 +2170,7 @@ void Part::updateAboutBackendAction()
} }
} }
} // namespace Okular
#include "part.moc" #include "part.moc"

@ -59,10 +59,9 @@ class BookmarkList;
namespace Okular namespace Okular
{ {
class ExportFormat;
}
class BrowserExtension; class BrowserExtension;
class ExportFormat;
/** /**
* This is a "Part". It that does all the real work in a KPart * This is a "Part". It that does all the real work in a KPart
@ -274,6 +273,8 @@ class Part : public KParts::ReadOnlyPart, public Okular::DocumentObserver, publi
void slotGeneratorPreferences(); void slotGeneratorPreferences();
}; };
}
#endif #endif
/* kate: replace-tabs on; indent-width 4; */ /* kate: replace-tabs on; indent-width 4; */

Loading…
Cancel
Save