Fix KDirWatch problem description in Part::setWatchFileModeEnabled

The problem is actually not the global watch list in KDirWatch, but
KDirWatch::stopScan causes unintended side effects via KDirWatchPrivate::_isStopped.

This bug is tracked in bug report 400541.

CCBUG: 400190
remotes/origin/Applications/18.12
Michel Ludwig 7 years ago
parent 83103d6155
commit 2ea44c5291
  1. 5
      part.cpp

@ -1020,9 +1020,8 @@ bool Part::isWatchFileModeEnabled() const
void Part::setWatchFileModeEnabled(bool enabled)
{
// Don't call 'KDirWatch::stopScan()' in here (as of KDE Frameworks 5.51.0)!
// KDirWatch maintains one global watch list per application only. Calling 'stopScan'
// could therefore affect other code paths that make use of KDirWatch
// Don't call 'KDirWatch::stopScan()' in here (as of KDE Frameworks 5.51.0, see bug 400541)!
// 'KDirWatch::stopScan' has a bug that may affect other code paths that make use of KDirWatch
// (other loaded KParts, for example).
if( isWatchFileModeEnabled() == enabled )
{

Loading…
Cancel
Save