From 2ea44c5291d80300f711fc5adaac833b2297d3d8 Mon Sep 17 00:00:00 2001 From: Michel Ludwig Date: Thu, 1 Nov 2018 07:48:32 +0100 Subject: [PATCH] Fix KDirWatch problem description in Part::setWatchFileModeEnabled The problem is actually not the global watch list in KDirWatch, but KDirWatch::stopScan causes unintended side effects via KDirWatchPrivate::_isStopped. This bug is tracked in bug report 400541. CCBUG: 400190 --- part.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/part.cpp b/part.cpp index 5324eb0d3..e6716df02 100644 --- a/part.cpp +++ b/part.cpp @@ -1020,9 +1020,8 @@ bool Part::isWatchFileModeEnabled() const void Part::setWatchFileModeEnabled(bool enabled) { - // Don't call 'KDirWatch::stopScan()' in here (as of KDE Frameworks 5.51.0)! - // KDirWatch maintains one global watch list per application only. Calling 'stopScan' - // could therefore affect other code paths that make use of KDirWatch + // Don't call 'KDirWatch::stopScan()' in here (as of KDE Frameworks 5.51.0, see bug 400541)! + // 'KDirWatch::stopScan' has a bug that may affect other code paths that make use of KDirWatch // (other loaded KParts, for example). if( isWatchFileModeEnabled() == enabled ) {