When `fetch_lyrics_for_current_song_in_background` is set to `yes`, and
an HTTP(S) stream is loaded with a long URL, ncmpcpp crashes due to the
length of the filename generated to store lyrics. This commit makes the
background lyrics fetcher ignore such streams, preventing the crash.
Addresses issue #380.
Terminals that don't restore the terminal state when a program exits display stdin incorrectly after quitting. This is not a bug in readline.h as its examples use termios in the same way.
* add configurable column widths
* reorder to match config file
* fix possibly misleading documentation
* fix crash when integer out of bounds
* parse config string during initial processing
* use std::bind with length of list
* fix division by zero error
* use list_of
* change escaped_list_separator variable names
* In #259 users request the ability to have ncmpcpp remain open when the
terminal has a small size. Previously ncmpcpp would exit when there
were less than 30 columns or 5 rows.
* After removing this constraint, ncmpcpp would freeze when terminal
sizes went below those thresholds.
* Upon debugging, it became clear that ncmpcpp wasn't frozen, it was
stuck in a very long for loop because it thought the display was
unreasonably large (resulting from integer overflow).
* Preventing that overflow allows ncmpcpp to handle small sizes
gracefully. No other changes to the rendering code were necessary.
Fixes#259
Although this can already be set via mpd_host, having a separate option
is cleaner, and doesn't require setting the host when ncmpcpp already
detects it correctly.
Andrzej Rybczak
djvs
James Le Cuirot
gardockt
George Abbott
Alex Balgavy
Denys Tynok
Drew Marino
Larson Carter
Zaidhaan Hussain
Robert Kaspar
leg7
squigz
Jeffrey Paul
Jinwoo Park
Jonathan Neidel
John Ferguson
tibequadorian
V