Summary:
Makes it easier to reuse the widget in other places that do not need the
extra columns with statistics.
Reviewers: mlaurent
Reviewed By: mlaurent
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D14433
Summary:
Use collectionFromId on demand when the resource is needed and wasn't
set in the collection passed to FolderSettings::forCollection.
For instance this happens in KMail::Util::mailingListsFromMessage
which uses item.parentCollection(), where the resource isn't set.
We do this on demand rather than in setCollection() because
in many cases (when other methods of FolderSettings are being called)
we don't actually need the resource.
Test Plan:
Reply followed by Forward-as-attachment would often hit
the assert for me, especially when using the toolbar buttons (probably
unrelated?).
Reviewers: mlaurent, dvratil, vkrause
Reviewed By: vkrause
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D14010
Summary:
and dropping a collection to define a new favorite.
BUG: 387873
Test Plan:
Tested all three features, reordering, adding, and dropping a mail.
Two issues left:
- adding a new favourite at a specific position (patch pending
for akonadi's favoritecollectionsmodel)
- the "+" when moving to reorder shouldn't appear, should be MoveAction only,
don't know if that's possible here though.
Reviewers: dvratil, mlaurent, mkoller
Reviewed By: dvratil
Subscribers: #kde_pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D9403
Daniel Vrátil
Laurent Montel
David Faure