modernize code

src/filter/filteractions/filteractionplaysound.cpp

@@ -20,7 +20,6 @@ using namespace MailCommon;
 
 FilterActionPlaySound::FilterActionPlaySound()
     : FilterActionWithTest(QStringLiteral("play sound"), i18n("Play Sound"))
-    , mPlayer(nullptr)
 {
 }
 

src/filter/filterimporter/filterimporterabstract.h

@@ -33,7 +33,7 @@ protected:
     QVector<MailFilter *> mListMailFilter;
     QStringList mEmptyFilter;
 private:
-    bool mInteractive;
+    const bool mInteractive;
 };
 }
 

src/folder/accountconfigorderdialog.cpp

@@ -39,10 +39,6 @@ struct InstanceStruct {
 class MailCommon::AccountConfigOrderDialogPrivate
 {
 public:
-    AccountConfigOrderDialogPrivate()
-    {
-    }
-
     QListWidget *mListAccount = nullptr;
     QPushButton *mUpButton = nullptr;
     QPushButton *mDownButton = nullptr;

src/folder/foldercollectionmonitor.cpp

@@ -27,10 +27,6 @@ using namespace MailCommon;
 class MailCommon::FolderCollectionMonitorPrivate
 {
 public:
-    FolderCollectionMonitorPrivate()
-    {
-    }
-
     Akonadi::ChangeRecorder *mMonitor = nullptr;
 };
 

src/folder/folderrequester.cpp

@@ -25,10 +25,6 @@ namespace MailCommon {
 class FolderRequesterPrivate
 {
 public:
-    FolderRequesterPrivate()
-    {
-    }
-
     Akonadi::Collection mCollection;
     QLineEdit *mEdit = nullptr;
     QString mSelectFolderTitleDialog;

src/folder/folderselectiondialog.cpp

@@ -33,10 +33,6 @@ namespace MailCommon {
 class Q_DECL_HIDDEN FolderSelectionDialog::FolderSelectionDialogPrivate
 {
 public:
-    FolderSelectionDialogPrivate()
-    {
-    }
-
     FolderTreeWidget *folderTreeWidget = nullptr;
     QPushButton *mUser1Button = nullptr;
     QPushButton *mOkButton = nullptr;

src/folder/foldertreewidget.cpp

@@ -44,10 +44,6 @@ namespace MailCommon {
 class Q_DECL_HIDDEN FolderTreeWidget::FolderTreeWidgetPrivate
 {
 public:
-    FolderTreeWidgetPrivate()
-    {
-    }
-
     QString filter;
     QString oldFilterStr;
     Akonadi::StatisticsProxyModel *filterModel = nullptr;

src/job/backupjob.h

@@ -93,7 +93,7 @@ private:
     ArchiveType mArchiveType = Zip;
     Akonadi::Collection mRootFolder;
     KArchive *mArchive = nullptr;
-    QWidget *mParentWidget = nullptr;
+    QWidget *const mParentWidget;
     int mArchivedMessages = 0;
     uint mArchivedSize = 0;
     QPointer<KPIM::ProgressItem> mProgressItem;

src/mdn/sendmdnhandler.cpp

@@ -38,7 +38,7 @@ public:
     void handleMessages();
 
     SendMdnHandler * const q;
-    IKernel *mKernel = nullptr;
+    IKernel *const mKernel;
     QQueue<Akonadi::Item> mItemQueue;
     QTimer mTimer;
 };