From 1662475b701bb792208fb9a3d7fcf14e7643b757 Mon Sep 17 00:00:00 2001
From: Laurent Montel <montel@kde.org>
Date: Sun, 6 Sep 2020 10:39:19 +0200
Subject: [PATCH] modernize code

---
 src/filter/filteractions/filteractionplaysound.cpp | 1 -
 src/filter/filterimporter/filterimporterabstract.h | 2 +-
 src/folder/accountconfigorderdialog.cpp            | 4 ----
 src/folder/foldercollectionmonitor.cpp             | 4 ----
 src/folder/folderrequester.cpp                     | 4 ----
 src/folder/folderselectiondialog.cpp               | 4 ----
 src/folder/foldertreewidget.cpp                    | 4 ----
 src/job/backupjob.h                                | 2 +-
 src/mdn/sendmdnhandler.cpp                         | 2 +-
 9 files changed, 3 insertions(+), 24 deletions(-)

diff --git a/src/filter/filteractions/filteractionplaysound.cpp b/src/filter/filteractions/filteractionplaysound.cpp
index 7b6f269..f2d17b2 100644
--- a/src/filter/filteractions/filteractionplaysound.cpp
+++ b/src/filter/filteractions/filteractionplaysound.cpp
@@ -20,7 +20,6 @@ using namespace MailCommon;
 
 FilterActionPlaySound::FilterActionPlaySound()
     : FilterActionWithTest(QStringLiteral("play sound"), i18n("Play Sound"))
-    , mPlayer(nullptr)
 {
 }
 
diff --git a/src/filter/filterimporter/filterimporterabstract.h b/src/filter/filterimporter/filterimporterabstract.h
index 16bf39a..d5ff80b 100644
--- a/src/filter/filterimporter/filterimporterabstract.h
+++ b/src/filter/filterimporter/filterimporterabstract.h
@@ -33,7 +33,7 @@ protected:
     QVector<MailFilter *> mListMailFilter;
     QStringList mEmptyFilter;
 private:
-    bool mInteractive;
+    const bool mInteractive;
 };
 }
 
diff --git a/src/folder/accountconfigorderdialog.cpp b/src/folder/accountconfigorderdialog.cpp
index 91577bb..66cbd13 100644
--- a/src/folder/accountconfigorderdialog.cpp
+++ b/src/folder/accountconfigorderdialog.cpp
@@ -39,10 +39,6 @@ struct InstanceStruct {
 class MailCommon::AccountConfigOrderDialogPrivate
 {
 public:
-    AccountConfigOrderDialogPrivate()
-    {
-    }
-
     QListWidget *mListAccount = nullptr;
     QPushButton *mUpButton = nullptr;
     QPushButton *mDownButton = nullptr;
diff --git a/src/folder/foldercollectionmonitor.cpp b/src/folder/foldercollectionmonitor.cpp
index 8168bb7..b9223b3 100644
--- a/src/folder/foldercollectionmonitor.cpp
+++ b/src/folder/foldercollectionmonitor.cpp
@@ -27,10 +27,6 @@ using namespace MailCommon;
 class MailCommon::FolderCollectionMonitorPrivate
 {
 public:
-    FolderCollectionMonitorPrivate()
-    {
-    }
-
     Akonadi::ChangeRecorder *mMonitor = nullptr;
 };
 
diff --git a/src/folder/folderrequester.cpp b/src/folder/folderrequester.cpp
index ea93a04..98fcb14 100644
--- a/src/folder/folderrequester.cpp
+++ b/src/folder/folderrequester.cpp
@@ -25,10 +25,6 @@ namespace MailCommon {
 class FolderRequesterPrivate
 {
 public:
-    FolderRequesterPrivate()
-    {
-    }
-
     Akonadi::Collection mCollection;
     QLineEdit *mEdit = nullptr;
     QString mSelectFolderTitleDialog;
diff --git a/src/folder/folderselectiondialog.cpp b/src/folder/folderselectiondialog.cpp
index 44b1aa0..cb46aa6 100644
--- a/src/folder/folderselectiondialog.cpp
+++ b/src/folder/folderselectiondialog.cpp
@@ -33,10 +33,6 @@ namespace MailCommon {
 class Q_DECL_HIDDEN FolderSelectionDialog::FolderSelectionDialogPrivate
 {
 public:
-    FolderSelectionDialogPrivate()
-    {
-    }
-
     FolderTreeWidget *folderTreeWidget = nullptr;
     QPushButton *mUser1Button = nullptr;
     QPushButton *mOkButton = nullptr;
diff --git a/src/folder/foldertreewidget.cpp b/src/folder/foldertreewidget.cpp
index 14bd052..6fa6e89 100644
--- a/src/folder/foldertreewidget.cpp
+++ b/src/folder/foldertreewidget.cpp
@@ -44,10 +44,6 @@ namespace MailCommon {
 class Q_DECL_HIDDEN FolderTreeWidget::FolderTreeWidgetPrivate
 {
 public:
-    FolderTreeWidgetPrivate()
-    {
-    }
-
     QString filter;
     QString oldFilterStr;
     Akonadi::StatisticsProxyModel *filterModel = nullptr;
diff --git a/src/job/backupjob.h b/src/job/backupjob.h
index ef46d2d..fced7a9 100644
--- a/src/job/backupjob.h
+++ b/src/job/backupjob.h
@@ -93,7 +93,7 @@ private:
     ArchiveType mArchiveType = Zip;
     Akonadi::Collection mRootFolder;
     KArchive *mArchive = nullptr;
-    QWidget *mParentWidget = nullptr;
+    QWidget *const mParentWidget;
     int mArchivedMessages = 0;
     uint mArchivedSize = 0;
     QPointer<KPIM::ProgressItem> mProgressItem;
diff --git a/src/mdn/sendmdnhandler.cpp b/src/mdn/sendmdnhandler.cpp
index c58041d..e7d7993 100644
--- a/src/mdn/sendmdnhandler.cpp
+++ b/src/mdn/sendmdnhandler.cpp
@@ -38,7 +38,7 @@ public:
     void handleMessages();
 
     SendMdnHandler * const q;
-    IKernel *mKernel = nullptr;
+    IKernel *const mKernel;
     QQueue<Akonadi::Item> mItemQueue;
     QTimer mTimer;
 };