tabbox: Do not add windows that have modal children

This fixes a porting typo. Previously, the modal was therefore
added twice, once for itself and once for its parent but we actually
do *not* want a window with a modal child at all.


(cherry picked from commit ff052c6d9c)

Co-authored-by: Kai Uwe Broulik <kde@privat.broulik.de>

src/tabbox/tabbox.cpp

@@ -191,12 +191,10 @@ Window *TabBoxHandlerImpl::clientToAddToList(Window *client) const
         Window *modal = client->findModal();
         if (modal == nullptr || modal == client) {
             ret = client;
+        } else if (!clientList().contains(modal)) {
+            ret = modal;
         } else {
-            if (clientList().contains(modal)) {
+            // nothing
-                ret = modal;
-            } else {
-                // nothing
-            }
         }
     }
     return ret;