- pass the right instance to KCModule

- don't leak a KConfig object
- don't use a KCModule widget for each tab

svn path=/trunk/kdebase/kwin/; revision=133741
remotes/origin/Plasma/5.0
Simon Hausmann 24 years ago
parent f92f6d8b4f
commit d8d4f8bfa1
  1. 2
      kcmkwin/kwindecoration/kwindecoration.cpp
  2. 6
      kcmkwin/kwinoptions/main.cpp
  3. 1
      kcmkwin/kwinoptions/main.h
  4. 2
      kcmkwin/kwinoptions/mouse.cpp
  5. 7
      kcmkwin/kwinoptions/mouse.h
  6. 6
      kcmkwin/kwinoptions/windows.cpp
  7. 17
      kcmkwin/kwinoptions/windows.h

@ -46,7 +46,7 @@ typedef KGenericFactory<KWinDecorationModule, QWidget> KWinDecoFactory;
K_EXPORT_COMPONENT_FACTORY( libkcm_kwindecoration, KWinDecoFactory("kcmkwindecoration") ); K_EXPORT_COMPONENT_FACTORY( libkcm_kwindecoration, KWinDecoFactory("kcmkwindecoration") );
KWinDecorationModule::KWinDecorationModule(QWidget* parent, const char* name, const QStringList &) KWinDecorationModule::KWinDecorationModule(QWidget* parent, const char* name, const QStringList &)
: KCModule(parent, name), DCOPObject("KWinClientDecoration") : KCModule(KWinDecoFactory::instance(), parent, name), DCOPObject("KWinClientDecoration")
{ {
KConfig kwinConfig("kwinrc"); KConfig kwinConfig("kwinrc");
kwinConfig.setGroup("Style"); kwinConfig.setGroup("Style");

@ -46,7 +46,7 @@ extern "C" {
} }
*/ */
KWinOptions::KWinOptions(QWidget *parent, const char *name, const QStringList &) KWinOptions::KWinOptions(QWidget *parent, const char *name, const QStringList &)
: KCModule(parent, name) : KCModule(KWinOptFactory::instance(), parent, name)
{ {
mConfig = new KConfig("kwinrc", false, true); mConfig = new KConfig("kwinrc", false, true);
@ -71,6 +71,10 @@ KWinOptions::KWinOptions(QWidget *parent, const char *name, const QStringList &)
connect(mAdvanced, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool))); connect(mAdvanced, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool)));
} }
KWinOptions::~KWinOptions()
{
delete mConfig;
}
void KWinOptions::load() void KWinOptions::load()
{ {

@ -41,6 +41,7 @@ class KWinOptions : public KCModule
public: public:
KWinOptions(QWidget *parent, const char *name, const QStringList &); KWinOptions(QWidget *parent, const char *name, const QStringList &);
virtual ~KWinOptions();
void load(); void load();
void save(); void save();

@ -47,7 +47,7 @@ KActionsConfig::~KActionsConfig ()
} }
KActionsConfig::KActionsConfig (KConfig *_config, QWidget * parent, const char *name) KActionsConfig::KActionsConfig (KConfig *_config, QWidget * parent, const char *name)
: KCModule (parent, name), config(_config) : QWidget (parent, name), config(_config)
{ {
QString strWin1, strWin2, strWin3, strAllKey, strAll1, strAll2, strAll3; QString strWin1, strWin2, strWin3, strAllKey, strAll1, strAll2, strAll3;
QVBoxLayout *layout = new QVBoxLayout(this, KDialog::marginHint(), KDialog::spacingHint()); QVBoxLayout *layout = new QVBoxLayout(this, KDialog::marginHint(), KDialog::spacingHint());

@ -25,9 +25,9 @@
class QComboBox; class QComboBox;
class KConfig; class KConfig;
#include <kcmodule.h> #include <qwidget.h>
class KActionsConfig : public KCModule class KActionsConfig : public QWidget
{ {
Q_OBJECT Q_OBJECT
@ -40,6 +40,9 @@ public:
void save(); void save();
void defaults(); void defaults();
signals:
void changed( bool state );
private slots: private slots:
void slotChanged(); void slotChanged();

@ -89,7 +89,7 @@ KFocusConfig::~KFocusConfig ()
// removed the LCD display over the slider - this is not good GUI design :) RNolden 051701 // removed the LCD display over the slider - this is not good GUI design :) RNolden 051701
KFocusConfig::KFocusConfig (KConfig *_config, QWidget * parent, const char *name) KFocusConfig::KFocusConfig (KConfig *_config, QWidget * parent, const char *name)
: KCModule (parent, name), config(_config) : QWidget (parent, name), config(_config)
{ {
QString wtstr; QString wtstr;
QBoxLayout *lay = new QVBoxLayout (this, KDialog::marginHint(), QBoxLayout *lay = new QVBoxLayout (this, KDialog::marginHint(),
@ -401,7 +401,7 @@ KAdvancedConfig::~KAdvancedConfig ()
} }
KAdvancedConfig::KAdvancedConfig (KConfig *_config, QWidget *parent, const char *name) KAdvancedConfig::KAdvancedConfig (KConfig *_config, QWidget *parent, const char *name)
: KCModule (parent, name), config(_config) : QWidget (parent, name), config(_config)
{ {
QString wtstr; QString wtstr;
QBoxLayout *lay = new QVBoxLayout (this, KDialog::marginHint(), QBoxLayout *lay = new QVBoxLayout (this, KDialog::marginHint(),
@ -653,7 +653,7 @@ KMovingConfig::~KMovingConfig ()
} }
KMovingConfig::KMovingConfig (KConfig *_config, QWidget *parent, const char *name) KMovingConfig::KMovingConfig (KConfig *_config, QWidget *parent, const char *name)
: KCModule (parent, name), config(_config) : QWidget (parent, name), config(_config)
{ {
QString wtstr; QString wtstr;
QBoxLayout *lay = new QVBoxLayout (this, KDialog::marginHint(), QBoxLayout *lay = new QVBoxLayout (this, KDialog::marginHint(),

@ -22,7 +22,7 @@
#ifndef __KWINDOWCONFIG_H__ #ifndef __KWINDOWCONFIG_H__
#define __KWINDOWCONFIG_H__ #define __KWINDOWCONFIG_H__
#include <kcmodule.h> #include <qwidget.h>
#include <config.h> #include <config.h>
class QRadioButton; class QRadioButton;
@ -62,7 +62,7 @@ class KIntNumInput;
class QSpinBox; class QSpinBox;
class KFocusConfig : public KCModule class KFocusConfig : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
@ -73,6 +73,9 @@ public:
void save(); void save();
void defaults(); void defaults();
signals:
void changed( bool state );
private slots: private slots:
void setAutoRaiseEnabled(); void setAutoRaiseEnabled();
void autoRaiseOnTog(bool);//CT 23Oct1998 void autoRaiseOnTog(bool);//CT 23Oct1998
@ -107,7 +110,7 @@ private:
KConfig *config; KConfig *config;
}; };
class KMovingConfig : public KCModule class KMovingConfig : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
@ -118,6 +121,9 @@ public:
void save(); void save();
void defaults(); void defaults();
signals:
void changed( bool state );
private slots: private slots:
void slotChanged(); void slotChanged();
@ -159,7 +165,7 @@ private:
}; };
class KAdvancedConfig : public KCModule class KAdvancedConfig : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
@ -170,6 +176,9 @@ public:
void save(); void save();
void defaults(); void defaults();
signals:
void changed( bool state );
private slots: private slots:
void slotChanged(); void slotChanged();
void shadeHoverChanged(bool); void shadeHoverChanged(bool);

Loading…
Cancel
Save