Also in save() just clear _previewedProperties; logically it wouldn't be
holding any properties that weren't set on _tempProfile, since all those
properties have been saved by the changeProfile() call, clear() makes
sense.
The difference is the preview isn't triggered on hover, you now have to
select a color scheme in the model to trigger a preview.
The font selection dialog works the same way (i.e. select to preview, not
just hover), and that seems to work quite well.
We want to be able to build without X11 support even if some of the used
libraries may not work w/o X11 themselves yet or need to be built with
X11 support for other reverse dependencies.
HAVE_X11 already exists and is set automagically so far, but using
-DCMAKE_DISABLE_FIND_PACKAGE_X11 will break if any dependencies list X11
as required in their cmake config.
Introducing this option means there is no behavior change by default,
cmake will just skip finding X11 or adding unwanted features if the
option is enabled.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
For clarity, the VT state machine has some comments where it differs
from the diagram from vt100.net. Add comments for some transitions on
String Terminator (ST / 0x9C) which appear on the diagram, but which
were already handled in the "anywhere" state.
Reported here:
https://mail.kde.org/pipermail/konsole-devel/2022-July/041429.html
- Use delete[] to free array allocated with new.
- Don't separate two cases which are handled identically.
- In vt100 parsing state machine no need to handle in specific states
characters which are handles identically in all states.
- The line separating commands may appear never, always, or when showing
URL hints.
- Up/Down arrows may be translated to a number of Left/Right arrows.
A UI for those options was also added.
"Delete" instead of "Remove" makes it more obvious the data is gone
afterwards, not just removed from a list.
Also use KMessageBox::warningYesNo instead of the helper method
KMessageBox::messageBox.
And fix missing i18n markup of menu entry.
Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour
of actions terms.
Also use KMessageBox::warningYesNo instead of the helper method
KMessageBox::messageBox.
Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour
of actions terms.