Script Kiddy
f45836543c
SVN_SILENT made messages (.desktop file)
15 years ago
Jekyll Wu
1772401647
Rename for consistency
...
In '-p 2222', -p is the option and 2222 is its argument.
noOptionsArguments ==> noArgumentOptions
singleOptionArguments ==> singleArgumentOptions
argChar ==> optionChar
15 years ago
Jekyll Wu
c4ab3d6c6d
Make the parsing of ssh command more robust, or more complicated.
...
It now can deal with both '-p 2222' and '-p2222'.
This is a follow up of 869cdb1090
CCBUG: 281621
15 years ago
Jekyll Wu
7d2f153ae6
Warn users they may need to restart konsole to see transparent background.
...
If desktop effect is enabled only after konsole has started, then
users need to restart konsole to see transparent background.
FEATURE: 169305
FIXED-IN: 4.8
15 years ago
Script Kiddy
3ca9d38075
SVN_SILENT made messages (.desktop file)
15 years ago
Script Kiddy
d7ed89c473
SVN_SILENT made messages (.desktop file)
15 years ago
Jekyll Wu
1233aa0f97
Initialize _maxLineCount in the initilization list directly.
15 years ago
Jekyll Wu
02a821887f
Remove unused methods maxNbLines() .
15 years ago
Jekyll Wu
57a83187ce
Remove unused member variable m_logFileName.
15 years ago
Jekyll Wu
87b98de419
Rename member variable m_histType to _historyType.
15 years ago
Jekyll Wu
5e8a76c302
Delete long obsolete method HistroyScroll:getCell().
...
This method is not used anymore, so it should be safe to remove.
15 years ago
Jekyll Wu
45daca783f
Declare HistoryFile::isMapped() as const method.
15 years ago
Jekyll Wu
4455c2a59f
Rename member variable fileMap and readWriteBalance.
15 years ago
Jekyll Wu
31ba6915b2
Rename member variable length to _length.
15 years ago
Jekyll Wu
02165475ea
Rename member variable tmpFile to _tmpFile.
15 years ago
Jekyll Wu
1f1b54e733
Rename member varibale ion to _fd.
...
It store an file descriptor, so _fd is more natural than ion.
15 years ago
Jekyll Wu
75017ee579
It is not a good idea to #include <KDebug> in SessionController.h
...
Except increasing building time, it also hides the problem of some
missing #include in other source files.
15 years ago
Jekyll Wu
57412dce63
comment out unused variable rowIndex.
15 years ago
Jekyll Wu
e83bc55fa4
Do not call selectedRow() at the end of tableSelectionChanged().
...
That line will cause infinite growing stack when Ctrl+A is pressed and
finally make konsole crash .
BUG: 281375
FIXED-IN: 4.8
15 years ago
Jekyll Wu
96c0f3a44e
No need to call tableSelectionChanged() explicitly in populateTable().
...
The previous call to selectedRow() should have alreaddy triggered
tableSelectionChanged() automatically.
15 years ago
Jekyll Wu
ce496b5933
Make the code a bit more readable.
15 years ago
Jekyll Wu
b7e4742eb6
add KDialog:: prefix before ButtonCode.
15 years ago
Jekyll Wu
ca7beebb0e
KTabWidget is not used by konsole yet.
15 years ago
Jekyll Wu
50a38c2fcb
small changes with #include .
15 years ago
Jekyll Wu
e828def700
Reorgnazie some #include.
15 years ago
Jekyll Wu
de61d40c63
Include Qt headers in the form of "#include <Module/Class>"
15 years ago
Jekyll Wu
f78b734ef2
Remove unused #include .
15 years ago
Jekyll Wu
0f89f1bba9
Check the validity of context menu after it gets closed.
...
The patch is from Francesco Cecconi <francesco.cecconi@gmail.com>,
with slight modification by committer.
BUG: 233377
FIXED-in : 4.8
15 years ago
Jekyll Wu
d90862d060
replace Q_SLOTS with slots.
15 years ago
Jekyll Wu
4b02eba623
Change slotClose() as private slot, since it is not used externally.
15 years ago
Jekyll Wu
6d08d04b56
adjust indentation to 4 spaces.
15 years ago
Jekyll Wu
1b5d836219
Add KDialog:: prefix for ButtonCode.
...
Ok, Cancel and Default are so generic that they look ambiguous without
the KDialog:: prefix.
15 years ago
Jekyll Wu
d99422730f
Less one-liner definitions for class methods .
...
This really hurts readability, especially when they appear successively.
15 years ago
Jekyll Wu
976077e37f
Do not select the fixed size mode by default.
...
Current code always sets the line count spinbox as focused and selected,
even when the current setting of history size is no history or unlimited
history. This is counter-intuitive and may confuse users.
15 years ago
Jekyll Wu
0012355e2e
slight adjustment of code layout. No functionality changes.
15 years ago
Jekyll Wu
6f3b4bbab6
Use "{ }" consistently in "if... else..." statements.
15 years ago
Jekyll Wu
0016b3c0c2
remove the TODO about unicode charcter composition, which is done.
15 years ago
Jekyll Wu
050454280b
Remove emacs mode information from the bottom of some source files.
...
This is a follow-up of commit dd9df43b44
15 years ago
Jekyll Wu
495b66f705
member _profileKey is not used anymore.
15 years ago
Jekyll Wu
2818d96536
Calling Session::run() on a already running sesssion makes no sense.
15 years ago
Jekyll Wu
c246e94fb5
Check whether the pointer _shellProcess is null before using it.
15 years ago
Yuri Chornoivan
cd50a74e7a
fix typo: varible -> variable
15 years ago
Jekyll Wu
3c562ef7fe
Add tootip for the KTextEdit widget within environment editor.
...
The code assumes one environment variable per line, but users may
not guess out that assumption without prompt.
15 years ago
Jekyll Wu
b916dd22d0
Rename 'persistant' to 'persistent'.
...
This is a common misspelling.
15 years ago
Jekyll Wu
a64772444f
reorganize some code to make it more readable.
...
This commit is purely about style and layourt. No functionality changes.
15 years ago
Jekyll Wu
5fb01e1017
slight improvement on style and readability.
15 years ago
Jekyll Wu
4b7ce422a5
The argument should not used before it passes the assertion.
15 years ago
Jekyll Wu
0c5a853e92
Add helper method createTempProfile() to reduce duplicated code.
15 years ago
Jekyll Wu
709445ceee
Make sure the _tempProfile is alwasy hidden.
15 years ago
Jekyll Wu
dec20a58a7
Assign new value to _tempProfile in a way clearly indicating its type.
...
This avoids potential doubt about its type and memory leak.
15 years ago