This isn't needed as QMenu takes care of deleting removed actions (that
are children of it). Confirmed with QObject::connect() call on
QObject::destroyed signal. And skimming the upstream QMenu::actionEvent()
code.
_preventClose has to be set to false right at the end, so as to prevent
crashes if the user selects the "close session" action from the context
menu in a Konsole KPart (e.g. the terminal panel in Dolphin).
Check menu object isn't null before deleting actions from it.
BUG: 429538
Traditionally konsole only was able to parse OSC sequences terminated with
non-standard BEL. In 324d78c07f konsole was extended to parse sequences
terminated by 7-bit ST (ESC \) as well. But the OSC responses were still
hardcoded to reply only with sequences with BEL. But replying to 7-bit ST
terminated sequences with a reply terminated by a non-standard terminator
is wrong.
This commit passes the terminator along and changes the response to match
the original request.
printf "\033]10;?\a" replies with "^[]10;rgb:fcfc/fcfc/fcfc^G"
printf "\033]10;?\033\\" replies with "^[]10;rgb:fcfc/fcfc/fcfc^[\"
- Make it confirm to the Label HIG (must start with a verb)
- Remove the redundant word "Current", which is implied
- Add the word "Rename" for clarity
- Rename the name of the resulting dialog for clarity
BUG: 426344
FIXED-IN: 20.12
This path adds a new feature for konsole, in the form of URL Escaped
Sequences. It allows programs to embbed URL's on texts much like
the anchor tag in html does
There's a allowed list of possible schemas for links, by default
it only accepts http://, https:// and file:// but the user can
add more if he wants.
The maximum amount of URL's accepted is 200, to prevent OOM
History is taken into account while scrooling
This also allowed me to remove a few includes of Profile.h
around the codebase, that used Profile::Ptr. now the compilation
is a bit faster and also does not recompile things as often.
This hides some actions from the main ContextMenu, so `Copy` is not
being display grayed out for no reason in the menu access when there's
no text selected
Don't call .data() for whenever we want to deal with the Smart
pointer. they have overloaded operators for those things, and we
should use them.
Makes the code much more pleasant.
QMenu since 5.15 is hidden when an action is triggered, this caused a
crash in Konsole when trying to access the text encoding menu.
Now Session emits a signal when the text encoding is changed, the
SessionController can connect to that singal to set the current codec in
the KCodecAction object.
Also fix the EditProfileDialog so that when the KCodecAction menu is
shown the currently set codec is selected.
BUG: 419526
FIXED-IN: 20.08
Assign the _view as the parent to the KXMLGuiFactory because the
factory is referencing the view widget as its associated widget. Since
the TerminalDisplay gets destructed first this is now a dangling
pointer. If the view is set as the parent the factory gets cleaned up
correctly. Also cleanup the created clientBuilder after destruction
because it can't have a parent and would probably leak memory.
BUG: 415762
FIXED-IN: 20.08.0
See also !87
This close method is also used when closing a Konsole session
via the X on the tabbar and tabheader.
FIXED-IN: 20.08.0
BUG: 420817
BUG: 420695
BUG: 415762
See merge request !87
Add new option "Monitor for Process Finishing" which
will send a notification when the current session's
long running process finishes.
FEATURE: 420053
GUI:
FIXED-IN: 20.08.0
CHANGELOG: Send notification when the session's foreground process finishes
Ahmad Samir
Gustavo Carneiro
Tomaz Canabrava
Kurt Hindenburg
Carlos Alves
Carlos Alves
Laurent Montel
Martin Hostettler
Nate Graham
Nicolas Fella
Maximilian Schiller
Will Westrop